Differential D24833

[KCM] Revert change to reduce size of screens in visualization
ClosedPublic
Actions

Authored by ngraham on Oct 21 2019, 3:05 PM.

Details

Reviewers
romangg
Group Reviewers
VDG
Plasma
Commits
R104:318c16f3c604: [KCM] Revert change to reduce size of screens in visualization
Summary

This was done in D23798, but in retrospect, that was a mistake. When more than one output
is connected, their representations in the visualization become tiny and their text gets
scrunched and elided. The old size worked better. So, let's revert to that.

BUG: 413142

Test Plan

Multi-screen display is much improved:

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 21 2019, 3:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 3:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 21 2019, 3:05 PM
romangg accepted this revision.Oct 21 2019, 3:08 PM
romangg edited the summary of this revision. (Show Details)

Yea it's better how it was before. But it could still be improved with some text/fonts/elide magic I guess.

5.17

This revision is now accepted and ready to land.Oct 21 2019, 3:09 PM
Closed by commit R104:318c16f3c604: [KCM] Revert change to reduce size of screens in visualization (authored by ngraham). · Explain WhyOct 21 2019, 3:11 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Oct 21 2019, 3:30 PM
In D24833#551421, @romangg wrote:

Yea it's better how it was before. But it could still be improved with some text/fonts/elide magic I guess.

Should be fully improved in D24834.

Revision Contents
Changeset List

PathPackages
Mkcm/package/contents/ui/Screen.qml (4 lines)

Diff 68447

View Options

kcm/package/contents/ui/Screen.qml

Loading...