Differential D24272

Use non-pixmap colorful icons from the icon theme in settings window's sidebar
ClosedPublic
Actions

Authored by ngraham on Sep 27 2019, 8:28 PM.

Details

Reviewers
stikonas
ndavis
Group Reviewers
VDG
KDE Partition Manager
Maniphest Tasks
T10165: Large category icons should all be colorful
Commits
R17:68d8c34535cb: Use non-pixmap colorful icons from the icon theme in settings window's sidebar
Summary

This patch changes the icons in the settings' window's sidebar to be all colorful, in
conformance with T10165 specifically, and the new Goal: Consistency goal more generally.

It also cleans up the code a tiny bit by using built-in constructor functionality to set
icons from the icon theme rather than leaving the icon blank in the constructor and then
setting it later.

Test Plan

Before:


After:

Diff Detail

Repository
R17 Partition Manager
Branch
use-all-colorful-icons-in-settings-window (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17108
Build 17126: arc lint + arc unit
ngraham requested review of this revision.Sep 27 2019, 8:28 PM
ngraham created this revision.
ndavis accepted this revision.Sep 27 2019, 8:35 PM
This revision is now accepted and ready to land.Sep 27 2019, 8:35 PM
stikonas accepted this revision.Sep 27 2019, 8:37 PM
ngraham closed this revision.Sep 27 2019, 9:21 PM

Revision Contents
Changeset List

Diff 66970

View Options

src/config/configureoptionsdialog.cpp

Loading...