Differential D24048

Inline styles from k.o/products moved to aether-sass
ClosedPublic
Actions

Authored by vladimirmikulic on Sep 18 2019, 11:51 AM.

Tags

None

Subscribers

Details

Reviewers

Commits

R883:1552192: Inline styles from k.o/products moved to aether-sass

Diff Detail

Branch

/trunk/www/sites/www

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16751
Build 16769: arc lint + arc unit

vladimirmikulic requested review of this revision.Sep 18 2019, 11:51 AM

vladimirmikulic created this revision.

Harbormaster completed remote builds in B16729: Diff 66372.Sep 18 2019, 11:51 AM

I also added a comment in the merge request in gitlab

products/index.php
7	Uncoment and link to 'https://cdn.kde.org/aether-devel/products.css'

This revision now requires changes to proceed.Sep 18 2019, 11:59 AM

styleEntry added 👍

Thanks can you update this diff with arc diff --conduit-uri=https://phabricator.kde.org/?

ognarb added inline comments.Sep 18 2019, 3:57 PM

products/index.php
7	'cssFile' => 'https://cdn.kde.org/aether-devel/products.css',

Updating D24048: Inline styles from k.o/products moved to aether-sass

Add cdn for products.css file

Harbormaster completed remote builds in B16751: Diff 66408.Sep 18 2019, 7:43 PM

Updated.

Updating D24048: Inline styles from k.o/products/kirigami moved to aether-sass

Harbormaster completed remote builds in B16758: Diff 66416.Sep 18 2019, 8:47 PM

ognarb accepted this revision.Sep 20 2019, 10:11 AM

This revision is now accepted and ready to land.Sep 20 2019, 10:11 AM

Closed by commit R883:1552192: Inline styles from k.o/products moved to aether-sass (authored by carlschwan, committed by ). · Explain WhySep 20 2019, 10:12 AM

This revision was automatically updated to reflect the committed changes.

Diffusion mentioned this in R883:1552192: Inline styles from k.o/products moved to aether-sass.

Revision Contents
Changeset List

			Path	Packages
M			products/index.php (25 lines)

Diff 66408

products/index.php

Loading...