Following on https://phabricator.kde.org/D23169, it turns out one can simplify the toolbuttons with menu rendering strongly by rendering the whole frame at once, and removing the code for detecting the presence of the menu alltogether. This makes for cleaner code with no visual difference with respect to how it should look (and no 'double-shadow').
Essentially this is the same patch as D23169, with more code removed, in order to avoid the rendering of the frame a second time around the arrow.
Details
Details
This is how toolbuttons with menu appear with this patch. (no change with respect to without)
Diff Detail
Diff Detail
- Repository
- R31 Breeze
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Hmm. I was thinking about using the button background of the dropdown menu for something like this mockup:
Comment Actions
Fair enough. In that case you do need the separate rendering, and thus the current simplification makes no sense. I can abandon this revision if you want.
Hugo