Simplify rendering of raised toolbuttons with menu
AbandonedPublic

Authored by hpereiradacosta on Tue, Aug 20, 3:42 PM.

Details

Reviewers
ndavis
Group Reviewers
Breeze
Summary

Following on https://phabricator.kde.org/D23169, it turns out one can simplify the toolbuttons with menu rendering strongly by rendering the whole frame at once, and removing the code for detecting the presence of the menu alltogether. This makes for cleaner code with no visual difference with respect to how it should look (and no 'double-shadow').
Essentially this is the same patch as D23169, with more code removed, in order to avoid the rendering of the frame a second time around the arrow.

Test Plan


This is how toolbuttons with menu appear with this patch. (no change with respect to without)

Diff Detail

Repository
R31 Breeze
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Aug 20, 3:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hpereiradacosta requested review of this revision.Tue, Aug 20, 3:42 PM
hpereiradacosta edited the summary of this revision. (Show Details)
ndavis added a comment.EditedWed, Aug 21, 12:40 AM

Hmm. I was thinking about using the button background of the dropdown menu for something like this mockup:

Hmm. I was thinking about using the button background of the dropdown menu for something like this mockup:

Fair enough. In that case you do need the separate rendering, and thus the current simplification makes no sense. I can abandon this revision if you want.

Hugo

Let's abandon it for now. We can always come back if we change our minds.

hpereiradacosta abandoned this revision.Wed, Aug 21, 12:47 PM