Differential D23221

Get rid of deprecated QSignalMapper() in KGoldRunner
ClosedPublic
Actions

Authored by yurchor on Aug 17 2019, 2:23 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Commits
R396:388f23c2f15e: Get rid of deprecated QSignalMapper() in KGoldRunner
Summary

QSignalMapper() is deprecated

https://build.kde.org/job/Applications/job/kgoldrunner/job/kf5-qt5%20FreeBSDQt5.13/6/warnings12Result/category.2119183113/

this patch replaces it with lambdas.

Test Plan
  1. Compile, install and run KGoldRunner.
  2. Start a game and select all menu items in the "Game", "Edit", and "settings" menus.

Diff Detail

Repository
R396 KGoldrunner
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15328
Build 15346: arc lint + arc unit
yurchor created this revision.Aug 17 2019, 2:23 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptAug 17 2019, 2:23 PM
yurchor requested review of this revision.Aug 17 2019, 2:23 PM
aacid added a subscriber: aacid.Aug 19 2019, 7:53 PM

Could i convince you to just capture what you need (game?) instead everything (=) ?

yurchor updated this revision to Diff 64090.Aug 20 2019, 6:19 AM

Do not capture everything, just capture this.

I do not know how to capture 'game' alone. Usage of '[game]' gives "capture of non-variable" and "invalid use of non-static data member" errors.

aacid accepted this revision.Aug 20 2019, 5:40 PM
This revision is now accepted and ready to land.Aug 20 2019, 5:40 PM
Closed by commit R396:388f23c2f15e: Get rid of deprecated QSignalMapper() in KGoldRunner (authored by yurchor). · Explain WhyAug 20 2019, 6:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kgoldrunner.h (7 lines)
Msrc/kgoldrunner.cpp (121 lines)

Diff 64090

View Options

src/kgoldrunner.h

Loading...
View Options

src/kgoldrunner.cpp

Loading...