Details
- Reviewers
dfaure vkrause - Group Reviewers
Calligra: 3.0
Diff Detail
- Repository
- R8 Calligra
- Branch
- kcalcore-5.12.0
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15180 Build 15198: arc lint + arc unit
| plan/src/plugins/filters/icalendar/export/icalendarexport.cpp | ||
|---|---|---|
| 30 | You can't test for the version number before including kcal[endar]core_version.h ... catch 22. This is going to need a cmake check for which header is available. Or kcalendarcore could keep installing a kcalcore_version.h file with the same contents as kcalendarcore_version.h? But then I also wonder if one day kcalendarcore_version.h will define KCALENDARCORE_VERSION rather than KCALCORE_VERSION... sounds like it should do both then... | |
This isn't wrong, but I'm surprised it's needed, we explicitly install headers in the old location too, for compatibility?
see https://cgit.kde.org/kcalcore.git/tree/src/CMakeLists.txt#n138 - seems to work here
But that leaves the problem of the version header, we also need to install that with the old name I think.
Yes, I was being blind.
But that leaves the problem of the version header, we also need to install that with the old name I think.
Indeed that was the actual problem.