Differential D2542

Simplify code
ClosedPublic
Actions

Authored by apol on Aug 23 2016, 2:41 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:892d33e067ba: Simplify code
Summary

Don't crash if m_stylesFallbackChain is empty

It can be reproduced by defining QT_QUICK_CONTROLS_STYLE=Breeze

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 6167.Aug 23 2016, 2:41 AM
apol retitled this revision from to Simplify code.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptAug 23 2016, 2:41 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 23 2016, 8:25 AM
mart edited edge metadata.
mart added inline comments.
src/kirigamiplugin.h
85

even tough tolocalfile should always behave correctly, did you actually try this on windows? a bit uneasy to remove platform specific code without testing it on that platform

This revision is now accepted and ready to land.Aug 23 2016, 8:25 AM
Closed by commit R169:892d33e067ba: Simplify code (authored by apol). · Explain WhyAug 23 2016, 11:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kirigamiplugin.h (9 lines)
Msrc/kirigamiplugin.cpp (7 lines)

Diff 6167

View Options

src/kirigamiplugin.h

Loading...
View Options

src/kirigamiplugin.cpp

Loading...