Fix build with Qt 5.9
ClosedPublic
Actions

Authored by wbauer on Jul 12 2019, 9:17 AM.

Details

Reviewers

Commits

R220:9acb42845378: Fix build with Qt 5.9

Summary

QFontMetrics::horizontalAdvance() only exists since Qt 5.11.
So switch back to QFontMetrics::width() when building with lower versions.

BUG: 409737

Test Plan

Builds fine now with Qt 5.9.x and 5.13.0.

Repository

R220 Subversion Client (KDE SVN)

Lint

Lint Skipped

Unit

Unit Tests Skipped

Btw, on an unrelated note:
I just noticed that it doesn't actually specify a minimum Qt version, even though it seems to be the intention:

set(QT_MIN_VERSION 5.9.0)
find_package(Qt5 REQUIRED COMPONENTS
    Core DBus Gui Sql Widgets Xml
)

Remove accidental trailing spaces.

Thx.

This revision is now accepted and ready to land.Jul 12 2019, 1:47 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/svnfrontend/graphtree/drawparams.cpp (40 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61627			Jul 12 2019, 9:06 AM	★	★
Diff 2	61632			Jul 12 2019, 9:35 AM	★	★
Diff 3	61660	a5657ec	R220:9acb42845378a2278c5edd9e900a3d622e320ea1	Jul 12 2019, 2:10 PM	★	★