move various properties away from qapp and to kaboutdata
ClosedPublic

Authored by sitter on Jun 14 2019, 1:17 PM.

Details

Summary

this is possible now that we actually call KAboutData::setApplicationData
which forwards a whole bunch of settings to the qapp

all calls are replaced by KAboutData::setApplicationData

Test Plan

--version|author|help work as expected

Diff Detail

Repository
R871 DrKonqi
Branch
Plasma/5.16
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12815
Build 12833: arc lint + arc unit
sitter created this revision.Jun 14 2019, 1:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 14 2019, 1:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jun 14 2019, 1:17 PM
kossebau accepted this revision.Jun 14 2019, 1:44 PM

I would leave out the explicit setting of otherwise default values, but people's preferences differ :)

src/main.cpp
78

That is the default (in case no homepage is given)., other places then do not set it explicitly, for consistency might also do this here.

79

This also is the implicit value, composed from (default) organization domain and the component name (as defined in the API docs contract). Other places also do not set it explicitly, so one might also not do this here.

This revision is now accepted and ready to land.Jun 14 2019, 1:44 PM
sitter updated this revision to Diff 59796.Jun 14 2019, 2:41 PM

ditch explicit values

sitter edited the summary of this revision. (Show Details)Jun 14 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.