Differential D2405

Fix crash when using K and L shortcuts
ClosedPublic
Actions

Authored by dkazakov on Aug 11 2016, 10:32 AM.

Details

Reviewers
woltherav
Group Reviewers
Krita
Maniphest Tasks
T3442: Crash in K,L shortcuts
Commits
R37:42e434f09083: Fix crash when using K and L shortcuts
Summary

We shouldn't fetch the RGB triplets from the grayscale color data

Fixes T3442
BUG:366378

Test Plan

I'm not sure if other methods of LcmsColorProfileContainer need changes like that...

Diff Detail

Repository
R37 Krita
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dkazakov updated this revision to Diff 5825.Aug 11 2016, 10:32 AM
dkazakov retitled this revision from to Fix crash when using K and L shortcuts.
dkazakov updated this object.
dkazakov edited the test plan for this revision. (Show Details)
dkazakov added a task: T3442: Crash in K,L shortcuts.
dkazakov edited the test plan for this revision. (Show Details)Aug 11 2016, 10:33 AM
dkazakov added reviewers: Krita, woltherav.
woltherav accepted this revision.Aug 11 2016, 1:04 PM
woltherav edited edge metadata.

Looks good to me, my programming skills aren't good enough to tell what I did wrong in the first place though...

This revision is now accepted and ready to land.Aug 11 2016, 1:04 PM
Closed by commit R37:42e434f09083: Fix crash when using K and L shortcuts (authored by dkazakov). · Explain WhyAug 11 2016, 2:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5825

View Options

plugins/color/lcms2engine/colorprofiles/LcmsColorProfileContainer.cpp

Loading...