Similar to the line ending style, add support for line start style for the Straight Line annotation tool
Details
Details
- Reviewers
tobiasdeiminger - Group Reviewers
Okular - Commits
- R223:59a86c3f14c5: Okular Annotation: add support for line start style for Straight Line tool
- Go to Configure annotations
- Create (or edit existing) Straight Line tool
- Set the ‘Line Start’ option on Style and Apply
- Use the Straight Line tool to draw a line and check the line starting style.
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Thanks, LGTM. If nobody objects I'll accept and land this on master the day after tomorrow.
ui/annotationwidgets.cpp | ||
---|---|---|
556 | You could say for ( const QString &i: { /* ... */ } ) here? I think auto i adds an unnecessary QString copy constructor call (but negligible because COW and no hot path), and there's no need for auto deduction because the type is simple. |
Comment Actions
@knambiar The config dialog for polygon annotations has seemingly regressed with recent changes:
Inner color overlaps with Line Start. Would you still be around for a fix?