This fixes the slicing issue for (de)serialization brought up during the
KF5 review. Maybe even more important, this enables us to transform both
classes into simple value types. That would not only be more efficient by
avoiding some extra allocations, it would also enable direct consumption
of those types from QML.
Details
Details
- Reviewers
winterz - Commits
- R172:518ca5592cbe: Don't inherit Attendee from Person
Diff Detail
Diff Detail
- Repository
- R172 KCalendar Core
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
deprecate fullName() and replace with fullEmail()?
src/person_p.h | ||
---|---|---|
30 | fullEmailAddressHelper() instead of fullNameHelper)( ? |
Comment Actions
Right, I'm not particular happy with the "fullName()" name either. IMHO that's a separate change though, this change did not introduce that name.