Differential D20297

Scope loop variable correctly
ClosedPublic
Actions

Authored by vkrause on Apr 6 2019, 10:28 AM.

Details

Reviewers
dvratil
Commits
R172:5d1ce2e5de80: Port these loops to range for
Summary

Makes changes to the above code easier.

Diff Detail

Repository
R172 KCalendar Core
Branch
sortUnique
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10512
Build 10530: arc lint + arc unit
vkrause created this revision.Apr 6 2019, 10:28 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 6 2019, 10:28 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 6 2019, 10:28 AM
dvratil added a subscriber: dvratil.Apr 6 2019, 10:31 AM

This could be just ported to a ranged-based for loop, right? Or does the SortedList has some special treatment for`opeator[]`?

vkrause added a comment.Apr 6 2019, 10:41 AM

Right, but maybe lets do this once the porting patches are in, I'm reluctant to pile more changes on top of that before it's all confirmed by review/CI, so that if something breaks it's easier to track it back.

dvratil accepted this revision.Apr 6 2019, 11:25 AM
This revision is now accepted and ready to land.Apr 6 2019, 11:25 AM
vkrause updated this revision to Diff 55546.Apr 6 2019, 12:23 PM

Changed to range-for now anyway, as the same problem occured in more places and I had to revisit the entire patch set anyway.

dvratil accepted this revision.Apr 6 2019, 10:55 PM
Closed by commit R172:5d1ce2e5de80: Port these loops to range for (authored by vkrause). · Explain WhyApr 7 2019, 9:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/recurrence.cpp (26 lines)

Diff 55546

View Options

src/recurrence.cpp

Loading...