Details
Details
- Reviewers
rempt dkazakov - Group Reviewers
Krita - Maniphest Tasks
- T7503: Port all Q_ASSERTS to KIS_SAFE_ASSERT
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8982 Build 9000: arc lint + arc unit
Comment Actions
Hi, @sourabhboss!
It would be preferable to use KIS_ASSERT_RECOVER and KIS_ASSERT_RECOVER_RETURN (and their _SAFE counterparts) here :)
plugins/tools/selectiontools/kis_tool_select_elliptical.cc | ||
---|---|---|
55 | recover-version of the assert is expected to have a recover-branch, like KIS_SAFE_ASSERT_RECOVER(kisCanvas) { // do something to recover } I guess in this case you wanted to use KIS_SAFE_ASSERT_RECOVER_RETURN(kisCanvas); | |
plugins/tools/selectiontools/kis_tool_select_similar.cc | ||
167 | Same here |
Comment Actions
Hi, @sourabhboss!
Did you try to compile your patch before uploading for review? It looks like it doesn't compile.