Differential D17616

[SMS App] Improve "No devices available" warning
ClosedPublic
Actions

Authored by sredman on Dec 16 2018, 2:00 AM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:037543e42b2b: [SMS App] Improve "No devices available" warning
Summary

Make "No devices available" warning more obvious, add explaination

New warning:

With mouseover explanation:

Test Plan
  • Open app with remote device connected, everything behaves as normal
  • Disconnect remote device, observe warning at top of dialogue
  • Mouse over warning, be told what the situation means for your use of the app
    • Note that, due to bug 401587, it is not actually possible to view cached content. That will be fixed eventually.

Diff Detail

Repository
R224 KDE Connect
Branch
smsapp-improve-disconnect-warning
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8926
Build 8944: arc lint + arc unit
sredman created this revision.Dec 16 2018, 2:00 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 16 2018, 2:00 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Dec 16 2018, 2:00 AM
sredman edited the summary of this revision. (Show Details)Dec 16 2018, 2:01 AM
apol added a subscriber: apol.Dec 17 2018, 2:32 AM
apol added inline comments.
smsapp/qml/ConversationList.qml
38

Use a MouseArea?

40

anchors.fill: parent

then you can remove a bunch of code.

sredman updated this revision to Diff 47747.Dec 18 2018, 6:11 AM
  • Change button for MouseArea
sredman marked 2 inline comments as done.Dec 18 2018, 6:11 AM
apol accepted this revision.Jan 22 2019, 1:47 AM
This revision is now accepted and ready to land.Jan 22 2019, 1:47 AM
sredman planned changes to this revision.Jan 23 2019, 1:28 AM

I just noticed today that the tooltip disappears after a few seconds. I will have to find a solution to this problem.

sredman updated this revision to Diff 52701.Feb 27 2019, 6:17 AM

Rebase on master

This revision is now accepted and ready to land.Feb 27 2019, 6:17 AM
sredman updated this revision to Diff 52702.Feb 27 2019, 6:18 AM

Un-upload practically the entire repository.

sredman updated this revision to Diff 54272.Mar 18 2019, 9:57 PM
  • Rebase on master
  • Specify tooltip timeout
    • The documentation says -1 is the default, but apparently that wasn't working. With -1 expicitally specified, the no devices warning tooltip does not time out
Closed by commit R224:037543e42b2b: [SMS App] Improve "No devices available" warning (authored by sredman). · Explain WhyMar 18 2019, 10:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmsapp/qml/ConversationList.qml (24 lines)

Diff 52702

View Options

smsapp/qml/ConversationList.qml

Loading...