SieveEditor: port to libksieve API changes
ClosedPublic
Actions

Authored by dfaure on Jul 16 2016, 8:55 AM.

Details

Reviewers

mlaurent
dvratil

Commits

Summary

same changes as those done in managesievescriptsdialog.cpp

Test Plan

sieveeditor: check syntax, and upload, with and without errors.

Repository

R43 KDE PIM

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

dfaure retitled this revision from to SieveEditor: port to libksieve API changes.

dfaure updated this object.

dfaure edited the test plan for this revision. (Show Details)

dfaure added a reviewer: mlaurent.

dfaure added a subscriber: KDE PIM.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

Update libksieve version requirement

Seems ok for me.
Ship it

This revision is now accepted and ready to land.Jul 16 2016, 10:36 AM

dvratil added a reviewer: dvratil.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (2 lines)
M			sieveeditor/CMakeLists.txt (2 lines)
M			sieveeditor/src/sieveeditorpagewidget.h (2 lines)
M			sieveeditor/src/sieveeditorpagewidget.cpp (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5223	5f5bedc		Jul 16 2016, 8:55 AM	★	★
Diff 2	5225	5f5bedc	Update libksieve version requirement	Jul 16 2016, 9:01 AM	★	★
Diff 3	5339	42613b1	rKDEPIM182531280c34f5ea6b427f642d78f457eb50601f	Jul 19 2016, 10:04 PM	★	★