Differential D18917

Fix Profile save behavior
ClosedPublic
Actions

Authored by rizzitello on Feb 11 2019, 3:00 AM.

Details

Reviewers
patrickelectric
tcanabrava
laysrodrigues
Commits
R231:bb295e6e4255: Fix Profile save behavior
R231:c2f11a5b444e: Fix save behavior
Summary

Profiles were not being saved correctly before when askToSave was run it would save to the new index not the
old

Test Plan

make several profiles with some data, change data in one , select new profile , save when asked and check the
correct profile was written to

Diff Detail

Repository
R231 Atelier
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello requested review of this revision.Feb 11 2019, 3:00 AM
rizzitello created this revision.
rizzitello retitled this revision from Fix save behavior to Fix Profile save behavior.Feb 11 2019, 3:01 AM
rizzitello edited the summary of this revision. (Show Details)
rizzitello added reviewers: patrickelectric, tcanabrava, laysrodrigues.
rizzitello added a project: Atelier.
laysrodrigues accepted this revision.Feb 11 2019, 5:02 PM
This revision is now accepted and ready to land.Feb 11 2019, 5:02 PM
patrickelectric accepted this revision.Feb 11 2019, 5:37 PM
Closed by commit R231:c2f11a5b444e: Fix save behavior (authored by rizzitello). · Explain WhyFeb 11 2019, 5:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51428

View Options

src/dialogs/profilesdialog.h

Loading...
View Options

src/dialogs/profilesdialog.cpp

Loading...