Differential D18837

Fix missing shadows on C/C++ header mimetype icons
ClosedPublic
Actions

Authored by ndavis on Feb 8 2019, 8:15 AM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R266:0eea3019324f: Fix missing shadows on C/C++ header mimetype icons
Summary

Some shadow objects had no fill because the gradients they referenced were missing.

BUG: 401793
FIXED-IN: 5.56

Diff Detail

Repository
R266 Breeze Icons
Branch
fix-text-x-hdr (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8016
Build 8034: arc lint + arc unit
ndavis created this revision.Feb 8 2019, 8:15 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 8 2019, 8:15 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Feb 8 2019, 8:15 AM
ngraham accepted this revision.Feb 8 2019, 4:34 PM
ngraham added a subscriber: ngraham.

Nice. Next can you improve the hideous pixellated "c" and "h" characters for the C and C++ source and header files?


Blech.

Interestingly enough, the C++ header file already has a nice "h":

This revision is now accepted and ready to land.Feb 8 2019, 4:34 PM
Closed by commit R266:0eea3019324f: Fix missing shadows on C/C++ header mimetype icons (authored by ndavis). · Explain WhyFeb 8 2019, 6:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51150

View Options

icons-dark/mimetypes/32/text-x-c++hdr.svg

Loading...
View Options

icons-dark/mimetypes/32/text-x-chdr.svg

Loading...
View Options

icons/mimetypes/32/text-x-c++hdr.svg

Loading...
View Options

icons/mimetypes/32/text-x-chdr.svg

Loading...