If an effect is installed or removed, then all not yet committed changes
will be lost. This is undesired behaviour.
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:bc34a9d65379: [kcmkwin] Don't discard unsaved changes when reloading effects model
Diff Detail
- Repository
- R108 KWin
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 7883 Build 7901: arc lint + arc unit
kcmkwin/common/effectmodel.cpp | ||
---|---|---|
474 | I think there's a problem here. Previously: we're now losing what we think kwin has In ::syncEffectsToKWin (line 484 here) If a user makes a change, and then we call reload, and then the user saves: m_effectsList[0]->effectStatus is the user set value so we'll write out the correct value in the config file all successfully but m_effectsList.at(it).effectStatus == m_effectsChanged.at(it).effectStatus so we won't notify kwin. |
Oh, I forgot about D18706
You could have just told me my comment was superseded by another commit and ignored it.
You didn't need to fix this.
Squash, ship as two things, whatever is easiest for you.