Differential D18733

With software rendering, use outlines instead of shadows on login & lock screen
ClosedPublic
Actions

Authored by ngraham on Feb 4 2019, 6:56 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:dbb19ba33304: With software rendering, use outlines instead of shadows on login & lock screen
Summary

QML shadows aren't supported with software rendering, so the white text often has poor readability.

This patch falls back to outlines when using software rendering to ensure adequate readability.

BUG: 398317
FIXED-IN: 5.15.0

Test Plan

No visual change with hardware rendering of some sort.

When forcing software rendering, I get outlines instead of shadows

Diff Detail

Repository
R120 Plasma Workspace
Branch
fall-back-to-outlines-with-software-rendering (branched from Plasma/5.15)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7875
Build 7893: arc lint + arc unit
ngraham created this revision.Feb 4 2019, 6:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 4 2019, 6:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 4 2019, 6:56 PM
ngraham updated this revision to Diff 50874.Feb 4 2019, 6:57 PM

Use a more descriptive variable name

davidedmundson accepted this revision.Feb 4 2019, 7:11 PM
This revision is now accepted and ready to land.Feb 4 2019, 7:11 PM
Closed by commit R120:dbb19ba33304: With software rendering, use outlines instead of shadows on login & lock screen (authored by ngraham). · Explain WhyFeb 4 2019, 7:14 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson added a comment.Feb 4 2019, 7:45 PM

FWIW, currently it'll only affect the lock screen as SDDM doesn't have any code (yet!) to enable software rendering.

ngraham added a comment.Feb 4 2019, 7:46 PM

Ah, well at least this part of the support is already done then! :)

Revision Contents
Changeset List

Diff 50874

View Options

lookandfeel/contents/components/Clock.qml

Loading...
View Options

lookandfeel/contents/components/UserDelegate.qml

Loading...