Differential D2123

Improve checksums calculation
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 8 2016, 9:50 PM.

Details

Reviewers
rthomsen
Commits
R36:fefce76c92fc: Improve checksums calculation
Summary
  1. Compute also the MD5 in another thread (useful if the archive is huge)
  2. Drop the member QByteArray. If the archive is huge this could be bad on systems with low amount of RAM. QCryptographicHash accepts a QIODevice, so we can just read the file three times.

Diff Detail

Repository
R36 Ark
Branch
refactor/checksum
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 5031.Jul 8 2016, 9:50 PM
elvisangelaccio retitled this revision from to Improve checksums calculation.
elvisangelaccio updated this object.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptJul 8 2016, 9:50 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Jul 9 2016, 1:42 PM
rthomsen edited edge metadata.

Looks good :)

This revision is now accepted and ready to land.Jul 9 2016, 1:42 PM
Closed by commit R36:fefce76c92fc: Improve checksums calculation (authored by elvisangelaccio). · Explain WhyJul 9 2016, 4:50 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:fefce76c92fc: Improve checksums calculation.

Revision Contents
Changeset List

Diff 5031

View Options

kerfuffle/propertiesdialog.h

Loading...
View Options

kerfuffle/propertiesdialog.cpp

Loading...