BuildView: Fix broken load of project plugin targets
ClosedPublic
Actions

Authored by loh.tar on Dec 3 2018, 7:29 PM.

Details

Reviewers

sars

Group Reviewers

Kate

Commits

Summary

Most changes are only a little code cosmetic, like unwrap lines or remove spaces

Test Plan

Here it was reproducible e.g. by changing between my sessions "kate" and "sonnet". I think you can guess what they are.

Start Kate with session "kate" -> Project Targets shown
Switch to "sonnet" -> No Project Targets shown. I think there are no (however) defined (any illuminating tip is appreciated)
Switch back to "kate" -> Also NO Project Targets shown, but should!

With this patch are at 3. the Project Targets back again

Repository

R40 Kate

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a project: Kate. · View Herald TranscriptDec 3 2018, 7:29 PM

Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript

loh.tar requested review of this revision.Dec 3 2018, 7:29 PM

It is maybe not optimal to "hide" a bug fix among a bunch of code cosmetics, but the fix is good :)

This revision is now accepted and ready to land.Dec 3 2018, 7:47 PM

In D17339#370901, @sars wrote:

It is maybe not optimal to "hide" a bug fix among a bunch of code cosmetics

I agree, but didn't want to bother with an extra patch nor ignore these ugliness

, but the fix is good :)

Thanks

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			addons/katebuild-plugin/plugin_katebuild.h (2 lines)
M			addons/katebuild-plugin/plugin_katebuild.cpp (36 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46812			Dec 3 2018, 7:24 PM	★	★
Diff 2	46908	e8496c6	R40:6686e5f6230dfeaaf307d0724b4acb793bfd73e3	Dec 5 2018, 4:48 PM	★	★