Details

Reviewers

vandenoever

Commits

R881:ec81047ac19d: Use pattern matching instead of if and else that return true and false

Summary

Add some nice rust syntactic sugar

Test Plan

All the tests still pass

Diff Detail

Repository

R881 Rust Qt Binding Generator

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4408
Build 4426: arc lint + arc unit

ognarb requested review of this revision.Oct 31 2018, 11:53 PM

ognarb created this revision.

Harbormaster completed remote builds in B4407: Diff 44599.Oct 31 2018, 11:53 PM

ognarb added a reviewer: vandenoever.Nov 1 2018, 12:12 AM

More small syntax change

Harbormaster completed remote builds in B4408: Diff 44600.Nov 1 2018, 12:55 AM

ognarb retitled this revision from Use pattern matching instead of if and else that return true and false to Use more rust syntactic sugar.Nov 1 2018, 12:56 AM

ognarb edited the summary of this revision. (Show Details)

ognarb edited the test plan for this revision. (Show Details)

Fix

Harbormaster completed remote builds in B4409: Diff 44601.Nov 1 2018, 12:58 AM

Fix

Harbormaster completed remote builds in B4410: Diff 44602.Nov 1 2018, 1:01 AM

Nice work, Carl.

I've marked some small things that could improve.

Do you have commit access?

src/configuration.rs
271–275	Good catch!
356	Now `t` can go too.
src/cpp.rs
2	generate -> generates
214	rustfmt does not break this line?
src/rust.rs
2	generate -> generates

This revision now requires changes to proceed.Nov 1 2018, 7:20 AM

Fix gramar error and apply some rustfmt change

Harbormaster completed remote builds in B4416: Diff 44610.Nov 1 2018, 9:31 AM

In D16576#351866, @vandenoever wrote:

Nice work, Carl.

Thanks :)

Do you have commit access?

Yes

src/configuration.rs
356	No `t` is needed in the line 354 `&t`
src/cpp.rs
214	rustfmt does break this line, but also create a lot more change.

Looks good. Thanks and welcome to Rust Qt Binding Generator.

This revision is now accepted and ready to land.Nov 1 2018, 10:16 AM

Closed by commit R881:ec81047ac19d: Use pattern matching instead of if and else that return true and false (authored by ognarb). · Explain WhyNov 1 2018, 10:23 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/configuration.rs (64 lines)
M			src/configuration_private.rs (2 lines)
M			src/cpp.rs (15 lines)
M			src/rust.rs (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44599	b8ebcfa		Oct 31 2018, 11:53 PM	★	★
Diff 2	44600	b8ebcfa	More small syntax change	Nov 1 2018, 12:55 AM	★	★
Diff 3	44601	b8ebcfa	Fix	Nov 1 2018, 12:58 AM	★	★
Diff 4	44602	b8ebcfa	Fix	Nov 1 2018, 1:01 AM	★	★
Diff 5	44610	b8ebcfa	Fix gramar error and apply some rustfmt change	Nov 1 2018, 9:31 AM	★	★
Diff 6	44615	b8ebcfa	R881:ec81047ac19d0a657d3ca5bcd47941df3f0460e5	Nov 1 2018, 9:30 AM	★	★

Use more rust syntactic sugar
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 44600

src/configuration.rs

src/configuration_private.rs

src/cpp.rs

src/rust.rs

Use more rust syntactic sugarClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 44600

src/configuration.rs

src/configuration_private.rs

src/cpp.rs

src/rust.rs

Use more rust syntactic sugar
ClosedPublic
Actions

Revision Contents
Changeset List