Details
Details
- Reviewers
broulik - Commits
- R108:1238c7bc4736: [autotests] Test ScriptedEffects stackingOrder
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
If the stackingOrder property needs special handing, shouldn't we have another test(i.e. test function)? (just a question)
autotests/integration/effects/scripts/effectsHandler.js | ||
---|---|---|
3 | var currentStackingOrder = effects.stackingOrder .map(function (window) { return window.caption; }) .join(); sendTestResponse("stackingOrder - " + effects.stackingOrder.length + " " + currentStackingOrder); I think it would be better. |
Comment Actions
shouldn't we have another test? (just a question)
I don't think we gain anything.
At the end of the day things either pass or they don't.
autotests/integration/effects/scripts/effectsHandler.js | ||
---|---|---|
3 | If this was "real" code, absolutely. It would be wrong to have any unchecked array access. But for a test, if you had anything other than 1 window we're going to abort anyway, and in unit tests I want to get errors. |