There was only one option hidden behind the andvanced section, just have
one line for refresh rate that is visible.
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Commits
- R104:51c93ef1f9eb: Remove Advanced section from screen config
Diff Detail
Diff Detail
- Repository
- R104 KScreen
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Approved; having a single item under an Advanced section didn't make much sense. Also, in the next patch we can use a nice simple QFormLayout for everything here, which is good because the misalignment of the Resolution ComboBox is driving me bananas! :)
Comment Actions
I can play with the drop-down sizes in a follow up change. To keep reviews as easy as possible, I prefer to make minimal changes with less chance of breakage :)
I'm unsure about how wide the combo boxes should be though, taking the full width would make them look weird.
Comment Actions
Don't explicitly mess with the combobox sizes; just use a QFormLayout and let it handle that for you.
Comment Actions
@ngraham https://phabricator.kde.org/D14326 fixes the alignement of the combo box, it's unrelated to using a form layout.