add albumId role to MediaPlayList and use it in ManageHeaderBar
ClosedPublic
Actions

Authored by mgallien on Jul 12 2018, 3:17 PM.

Details

Reviewers

astippich
januz

Commits

R255:b03252c8dc55: add albumId role to MediaPlayList and use it in ManageHeaderBar

Summary

add albumId role to MediaPlayList and use it in ManageHeaderBar

Test Plan

tests are OK

Diff Detail

Repository

R255 Elisa

Branch

albumIdInHeaderBar

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 846
Build 859: arc lint + arc unit

mgallien requested review of this revision.Jul 12 2018, 3:17 PM

mgallien created this revision.

Harbormaster completed remote builds in B787: Diff 37661.Jul 12 2018, 3:17 PM

Hey, thanks for working on this. I tried this in the links branch but it seems all albums are giving back zero (even after deleting/rebuilding the db).

console.log('id', elisa.manageHeaderBar.albumId)
// qml: id 0

@januz I will check but I think I know why.

include tests for DatabaseInterface for the albumId attribute of tracks
configure ManageHeaderBar to get albumId role from MediaPlayList

should fix the albumId always at 0

Harbormaster completed remote builds in B793: Diff 37670.Jul 12 2018, 8:44 PM

You forgot to set the role in elisaapplication.cpp similar to the other roles (it's done in c++). You changed the android main qml file instead (which is horribly outdated)

This revision now requires changes to proceed.Jul 14 2018, 1:11 PM

set the AlbumIdRole for ManageHeaderBar to read data from MediaPlayList

Harbormaster completed remote builds in B846: Diff 37758.Jul 14 2018, 5:13 PM

In D14080#291877, @astippich wrote:

You forgot to set the role in elisaapplication.cpp similar to the other roles (it's done in c++). You changed the android main qml file instead (which is horribly outdated)

Thanks @astippich, I had completely missed that.

Tested this on my branch and it works now, thanks guys

This revision was not accepted when it landed; it landed in state Needs Review.Jul 15 2018, 5:10 AM

Closed by commit R255:b03252c8dc55: add albumId role to MediaPlayList and use it in ManageHeaderBar (authored by mgallien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/databaseinterfacetest.cpp (11 lines)
M			autotests/manageheaderbartest.h (3 lines)
M			autotests/manageheaderbartest.cpp (419 lines)
M			autotests/mediaplaylisttest.cpp (12 lines)
M			src/android/ElisaMainWindow.qml (1 line)
M			src/databaseinterface.cpp (1 line)
M			src/elisaapplication.cpp (1 line)
M			src/manageheaderbar.h (25 lines)
M			src/manageheaderbar.cpp (41 lines)
M			src/mediaplaylist.h (1 line)
M			src/mediaplaylist.cpp (9 lines)
M			src/musicaudiotrack.h (4 lines)
M			src/musicaudiotrack.cpp (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37661	b22b135		Jul 12 2018, 3:17 PM	★	★
Diff 2	37670	b22b135	- include tests for DatabaseInterface for the albumId attribute of tracks	Jul 12 2018, 8:44 PM	★	★
Diff 3	37758	b22b135	- set the AlbumIdRole for ManageHeaderBar to read data from MediaPlayList	Jul 14 2018, 5:13 PM	★	★
Diff 4	37780	71977a6	R255:b03252c8dc555946ab0ac5558d9f8077932bc22d	Jul 15 2018, 5:09 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
f7b1e64d2c48	c462c8595e03	2638dafbc190	Matthieu Gallien	set the AlbumIdRole for ManageHeaderBar to read data from MediaPlayList	Jul 14 2018, 5:12 PM
2638dafbc190	3c59f55a133c	a11d4193a845	Matthieu Gallien	configure ManageHeaderBar to get albumId role from MediaPlayList	Jul 12 2018, 8:42 PM
a11d4193a845	d162767e9a20	a0a16ae79f8a	Matthieu Gallien	include tests for DatabaseInterface for the albumId attribute of tracks	Jul 12 2018, 8:42 PM
a0a16ae79f8a	92831f79ed7b	b22b13569436	Matthieu Gallien	add albumId role to MediaPlayList and use it in ManageHeaderBar (Show More…)	Jul 12 2018, 3:16 PM