Differential D14084

always display the title of the playlist entries
ClosedPublic
Actions

Authored by mgallien on Jul 13 2018, 5:54 AM.

Details

Reviewers
astippich
januz
Commits
R255:f31b6635f2e9: always display the title of the playlist entries
Summary

always display the title of the playlist entries

entries added from a filename now always show a title even before the metadata are read

Test Plan

tried adding tracks in playlist from command line arguments

Diff Detail

Repository
R255 Elisa
Branch
fixPlayList
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 799
Build 812: arc lint + arc unit
mgallien requested review of this revision.Jul 13 2018, 5:54 AM
mgallien created this revision.
mgallien updated this revision to Diff 37678.Jul 13 2018, 6:05 AM
  • also fix the album, album artist and artist roles not showing in PlayListEntry
januz accepted this revision.Jul 13 2018, 1:31 PM

LGTM. Tested this by adding MOD files to the playlist and now they show up correctly.
One small issue is that they are all inside a blank album (with only a CD icon) which looks a bit strange but that's a topic for another patch.

This revision is now accepted and ready to land.Jul 13 2018, 1:31 PM
Closed by commit R255:f31b6635f2e9: always display the title of the playlist entries (authored by mgallien). · Explain WhyJul 13 2018, 3:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37678

View Options

src/qml/MediaPlayListView.qml

Loading...
View Options

src/qml/PlayListEntry.qml

Loading...