unmerge albums by using the paths of their tracks
ClosedPublic
Actions

Authored by mgallien on Jun 7 2018, 9:38 PM.

Details

Reviewers

astippich
januz

Maniphest Tasks

T8953: Improve detection of different albums

Commits

R255:c39fb6c703f1: unmerge albums by using the paths of their tracks

Summary

unmerge albums by using the paths of their tracks

fix typo in DatabaseInterface::getDuplicateTrackIdFromTitleAlbumTrackDiscNumber

fix some problems with database due to errors in foreign keys management

duplicate albums if they look like the same but have a different path
where there tracks are located

BUG: 394332

fix mediaplaylisttest.cpp automatic tests after fixing bugs in the db

Test Plan

tests are OK

Diff Detail

Repository

R255 Elisa

Branch

duplicatedAlbums

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 235
Build 235: arc lint + arc unit

mgallien requested review of this revision.Jun 7 2018, 9:38 PM

mgallien created this revision.

mgallien added a task: T8953: Improve detection of different albums.Jun 7 2018, 9:43 PM

When I tried this the first time I got this error and the loading animation running constantly.

transaction failed QSqlError("", "Unable to begin transaction", "cannot start a transaction within a transaction") "Unable to begin transaction"

However, once I nuked the DB it loaded just fine and I can confirm this fixes the bug. Great work!

In D13423#275808, @januz wrote:
When I tried this the first time I got this error and the loading animation running constantly.
transaction failed QSqlError("", "Unable to begin transaction", "cannot start a transaction within a transaction") "Unable to begin transaction"
However, once I nuked the DB it loaded just fine and I can confirm this fixes the bug. Great work!

Thanks for your report. I will check the error before landing this.

Is using the path really the correct way to handle this? It could also be possible that some files from the same album are located in different folders. Reading the bug report, the difference is the artist of the album. But thinking of it, it could also be that the artists differ for each track of one album. Ideally, if album artist is tagged, this one should be used to split the albums.

fix upgrade path from older database schema of Elisa

Harbormaster completed remote builds in B235: Diff 36538.Jun 22 2018, 9:31 PM

astippich accepted this revision.Jun 24 2018, 8:59 AM

This revision is now accepted and ready to land.Jun 24 2018, 8:59 AM

Closed by commit R255:c39fb6c703f1: unmerge albums by using the paths of their tracks (authored by mgallien). · Explain WhyJun 24 2018, 11:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/databaseinterfacetest.cpp (325 lines)
M			autotests/mediaplaylisttest.cpp (16 lines)
M			src/databaseinterface.h (20 lines)
M			src/databaseinterface.cpp (259 lines)
M			src/musicalbum.h (4 lines)
M			src/musicalbum.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	35807	59e32f4		Jun 7 2018, 9:38 PM	★	★
Diff 2	36538	033e5ce	- fix upgrade path from older database schema of Elisa	Jun 22 2018, 9:31 PM	★	★
Diff 3	36596	033e5ce	R255:c39fb6c703f1421ca1c2d2d449d87ff5fc3af4f9	Jun 24 2018, 11:39 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
cb5e5b8b75bc	0fb72a9c7efb	fc107e18663f	Matthieu Gallien	fix upgrade path from older database schema of Elisa	Jun 22 2018, 9:28 PM
fc107e18663f	8d7ed919d15e	bd52c217fe6a	Matthieu Gallien	unmerge albums by using the paths of their tracks (Show More…)	Jun 7 2018, 9:35 PM
bd52c217fe6a	d9b8e2995f0a	e2e535d52fbd	Matthieu Gallien	demerge albums by using the paths of their tracks (Show More…)	Jun 7 2018, 8:17 PM
e2e535d52fbd	4dfb28e0ac86	033e5ce0841f	Matthieu Gallien	fix typo in DatabaseInterface::getDuplicateTrackIdFromTitleAlbumTrackDiscNumber	Jun 4 2018, 8:05 PM