Differential D1534

make the serializer a bit more robust
ClosedPublic
Actions

Authored by sebas on May 4 2016, 2:35 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R104:7497eb49a142: make the serializer a bit more robust
R104:94f235982af5: make the serializer a bit more robust
Summary

The daemon has some valid code pathes involving null configs. I've not
seen this particular part crashing, but it seems prudent to be a bit
more careful with the pointers we receive.

Also, debug message when writing fails, this seems to be a common
problem, and we should be able to debug this better when it happens.

Test Plan

autotests still pass

Diff Detail

Repository
R104 KScreen
Branch
sebas/fortifyserializer
Lint
No Linters Available
Unit
No Unit Test Coverage
sebas updated this revision to Diff 3633.May 4 2016, 2:35 AM
sebas retitled this revision from to make the serializer a bit more robust.
sebas updated this object.
sebas edited the test plan for this revision. (Show Details)
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 4 2016, 2:35 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin added a subscriber: graesslin.May 4 2016, 5:54 AM

would it be possible to have test cases for these issues?

sebas updated this revision to Diff 3647.May 4 2016, 10:56 PM
  • add autotests for null config behavior
graesslin accepted this revision.May 6 2016, 5:58 AM
graesslin added a reviewer: graesslin.

Thanks for adding the test case. I appreciate that!

This revision is now accepted and ready to land.May 6 2016, 5:58 AM
Closed by commit R104:7497eb49a142: make the serializer a bit more robust (authored by sebas). · Explain WhyMay 6 2016, 12:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/serializer.cpp (7 lines)
Mtests/kded/serializertest.cpp (17 lines)

Diff 3647

View Options

kded/serializer.cpp

Loading...
View Options

tests/kded/serializertest.cpp

Loading...