BUG: 391907
Details
- Reviewers
romangg - Group Reviewers
Plasma KWin - Commits
- R108:c629d282acce: [effects/glide] Do not animate logout screen
Diff Detail
- Repository
- R108 KWin
- Branch
- effects-glide-logout-screen
- Lint
No Linters Available - Unit
No Unit Test Coverage
effects/glide/glide.h | ||
---|---|---|
30 ↗ | (On Diff #35313) | QTimeLine is external stuff, that's not part of KWin. What if definition of QTimeLine will be changed in the future? |
effects/glide/glide.kcfg | ||
18 ↗ | (On Diff #35313) | I think this approach is better than hard coding stuff. Again, if you insist on hard coding it, I'll hard code it. |
effects/glide/glide.h | ||
---|---|---|
30 ↗ | (On Diff #35313) | It can only in Qt 6 and a pointer is still a pointer, all that the compiler needs to know is "this class exists" for this member variable. |
effects/glide/glide.h | ||
---|---|---|
30 ↗ | (On Diff #35313) | Some time ago, Hugo Pereira Da Costa added a good comment on forward-declaring Qt stuff:
Anyway, if you still think QTimeLine should be forward-declared, I'll update the diff. |
effects/glide/glide.cpp | ||
---|---|---|
45 | Any particular reason for using a QSet? (just curious) |
effects/glide/glide.cpp | ||
---|---|---|
45 | Fast lookup. |