Things still builds
Details
Details
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
- The current code only works if discount is installed into existing locations (discount_INCLUDE_DIR is never used), and as a user of the FindPackage, you don't have to care about the include directory. It comes from the target.
- The whole thing with targets vs variables: if you link against a double colon target, it fails at cmake time if something is wrong. If something is wrong with the variable, it fails at link time. E.g. trying to link discard::Lib fails at cmake time, linking ${discard_LIBRARIES} gives a link error.
Using targets is much less error prone, and in general encouraged.
Comment Actions
If noone disagrees i guess you can commit this in one week or so, i don't really have enough knowledge to discuss if this is better or worse.
Comment Actions
It's actually fixing the build when discount is in its own prefix.
Also I agree that it's better using targets.