Differential D11464

Refer to views by KMyMoneyViewBase
ClosedPublic
Actions

Authored by wojnilowicz on Mar 18 2018, 7:42 PM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:e0cc92082647: Refer to views by KMyMoneyViewBase

Summary

I want to refer to the views in a generic way in order to be able to manage them in a simple way i.e. through viewFrames and viewBases.
It's not possible fully right now, so many static_cast appears, but they will disappear with an advent of reworked signals framework.

Diff Detail

Repository

R261 KMyMoney

Lint

Lint Skipped

Unit

Unit Tests Skipped

wojnilowicz requested review of this revision.Mar 18 2018, 7:42 PM

wojnilowicz created this revision.

wojnilowicz updated this revision to Diff 30043.Mar 20 2018, 7:49 PM

Select payees view, select payee with transactions, select transaction tab of that payee, double click on a transaction -> crash

I have not investigated why that is or if it is due to my data, but I can reproduce it every time.

No crash this time.

Works for me now. I did not find any anomalies.

This revision is now accepted and ready to land.Mar 21 2018, 7:24 PM

Closed by commit R261:e0cc92082647: Refer to views by KMyMoneyViewBase (authored by wojnilowicz). · Explain WhyMar 21 2018, 7:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/dialogs/settings/ksettingskmymoney.cpp (2 lines)
M			kmymoney/reports/kreportchartview.cpp (3 lines)
M			kmymoney/views/kmymoneyview.h (22 lines)
M			kmymoney/views/kmymoneyview.cpp (459 lines)
M			kmymoney/views/simpleledgerview.h (26 lines)
M			kmymoney/views/simpleledgerview.cpp (115 lines)
M			kmymoney/views/viewenums.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29854			Mar 18 2018, 7:40 PM	★	★
Diff 2	30043			Mar 20 2018, 7:49 PM	★	★
Diff 3	30136			Mar 21 2018, 5:58 PM	★	★
Diff 4	30154	07d031b	R261:e0cc92082647d739e34b5895811c9a917979b8ef	Mar 21 2018, 7:30 PM	★	★