Differential D11406

add color coding of pos/neg amounts for 'posted value' column
ClosedPublic
Actions

Authored by mhubner on Mar 17 2018, 3:38 AM.

Tags

Subscribers

tbaumgart, wojnilowicz

Details

Reviewers

Group Reviewers

Commits

R261:07d031bc95b5: Add color coding of pos/neg amounts for 'posted value' column

Summary

add color coding of pos/neg amounts for 'posted value' column

Diff Detail

Repository

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

mhubner requested review of this revision.Mar 17 2018, 3:38 AM

mhubner created this revision.

add color coding of pos/neg amounts for 'posted value' column

mhubner added a reviewer: KMyMoney.Mar 17 2018, 3:41 AM

mhubner added a project: KMyMoney.

wojnilowicz added a subscriber: wojnilowicz.Mar 17 2018, 6:10 AM

wojnilowicz added inline comments.

kmymoney/models/accountsmodel.cpp
331	I would extend KMyMoneySettings::schemeColor by SchemeColor::Normal and use it as you did above with SchemeColor::Negative

tbaumgart requested changes to this revision.Mar 17 2018, 9:43 AM

tbaumgart added a subscriber: tbaumgart.

tbaumgart added inline comments.

kmymoney/models/accountsmodel.cpp
331	wojnilowicz means SchemeColor::Positive and I prefer that as well.

This revision now requires changes to proceed.Mar 17 2018, 9:43 AM

add color coding of pos/neg amounts for 'posted value' column

mhubner marked an inline comment as done.Mar 17 2018, 3:32 PM

Looks good to me. I'll take care of adding it to the repo.

This revision is now accepted and ready to land.Mar 17 2018, 3:55 PM

Closed by commit R261:07d031bc95b5: Add color coding of pos/neg amounts for 'posted value' column (authored by tbaumgart). · Explain WhyMar 20 2018, 7:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/models/accountsmodel.cpp (6 lines)

Diff 29733

kmymoney/models/accountsmodel.cpp

Loading...