The folder inclusion/exclusion configuration queries Solid for external media to exclude them, this adds a significant overhead to using FileIndexerConfig.
In most places it is merely used to check whether file indexing is enabled in general.
Details
Creating DolphinViewActionHandler which checks Baloo availability on Dolphin startup showed up as 3% cost in the profiler. After this change it is less than 0.4%.
- Verified that Baloo file places disappeared when disabling it
- Verified that Dolphin search still enabled and disabled additional search criteria depending on the folder you're searching in and that it is using baloosearch or filenamesearch accordingly; also verified that the folder cache is populated when this happens
Dolphin does not gray out sort options and additional roles for Baloo roles when disabled but that is a bug unrelated to this change
Diff Detail
- Repository
- R293 Baloo
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Ha! Wonderful, this touches a question I raised on kde-devel ML recently. Say we wanted to test this patch. We would need some kind of mock drive, right? I'd very much appreciate if you would lay out your thought on this.
Secondly this illustrates that my comprehension of ABI is still fragmentary. Obviously this is not breaking, but I thought it would.
Dolphin does not gray out sort options and additional roles for Baloo roles when disabled but that is a bug unrelated to this change
Didn't see that.