Fix bug 279861
https://.kde.org/show_bug.cgi?=279861
Details
Details
Diff Detail
Diff Detail
- Repository
- R36 Ark
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Tested and works as intented. The change makes sense. Nice work! :)
kerfuffle/addtoarchive.cpp | ||
---|---|---|
166 | Coding style: Please remove the spaces within the QLatin1Char(). |
Comment Actions
The logic for the bugfix looks ok.
But I would prefer to move this new code to a dedicated function ;)
kerfuffle/addtoarchive.cpp | ||
---|---|---|
162–169 | How about introducing a new (public) function? This would allow us to easily unit test it, in the future. |
Comment Actions
Thanks! Nice work :)
kerfuffle/addtoarchive.h | ||
---|---|---|
63 ↗ | (On Diff #2685) | The function should be const. |