As mentioned in a Debian Bug [887827] kcalcore can't be built
with cross compilation. On Linux we can simply use PkgConfig.
[887827] https://bugs.debian.org/887827
As mentioned in a Debian Bug [887827] kcalcore can't be built
with cross compilation. On Linux we can simply use PkgConfig.
[887827] https://bugs.debian.org/887827
build kcalcore
No Linters Available |
No Unit Test Coverage |
maybe we can also use pkgConfig on Windows and mac and make this file a lot more elegant and short?
cmake/FindLibIcal.cmake | ||
---|---|---|
4 | Please change it back to LibIcal_INCLUDE_DIRS. We're following the CMake policies and coding style recommendations Xxx_INCLUDE_DIRS The final set of include directories listed in one variable for use by client code. This should not be a cache entry. | |
19 | if/endif are not needed for pkgconfig calls |
@cgiboudeaux: did you checked on Windows? Is the whole WIN32 block is still needed, or can it removed completly?
cmake/FindLibIcal.cmake | ||
---|---|---|
4 | mmh i changed it because pkgconfig returns XXX_INCLUDEDIR and I thought so this is the more "stadardized" name. | |
20–22 | for the first I can understand, beause we don't want PkgConfig found line shown. | |
91 | if we don't if/endif the pkgconfig call, we can modify to |
https://community.kde.org/Policies/CMake_Coding_Style#.28Not.29_Using_pkg-config
putting something like if(NOT WIN32) around the pkg-config stuff is not necessary (and should be removed if it is somewhere). If pkg-config is not found, e.g. on Windows, the macros simply do nothing.
cmake/FindLibIcal.cmake | ||
---|---|---|
4 | and it's not :) What should be removed however is ${LibIcal_INCLUDE_DIRS}/libical at the bottom of this file. | |
20–22 | Because we don't need the pkg-config output. |
cmake/FindLibIcal.cmake | ||
---|---|---|
19 | still missing the QUIET keyword. | |
21 | Not needed here, it doesn't exist yet | |
22 | it's not the right place for that. See below | |
23 | Remove | |
37 | + ${PC_LibIcal_INCLUDEDIR} That's where we use the pkgconfig result | |
43–44 | + ${PC_LibIcal_LIBDIR} | |
50–51 | + ${PC_LibIcal_LIBDIR} |
we fixed it differently see: https://cgit.kde.org/kcalcore.git/commit/?id=6377808f5b5c46bbc61ecb054b3e59e5abe8959a