Adding config options to change letter to be searched in words in capital.
Details
- Reviewers
jjazeix - Group Reviewers
GCompris GCompris: Improvements - Maniphest Tasks
- T5936: letter_in_word: Adding a choice between capital and non-capital letters
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/activities/letter-in-word/LetterInWord.qml | ||
---|---|---|
69 | not a good variable name | |
143 | We can have a combobox with the 3 possible values instead: lowercase, uppercase and mixed (we randomly choose if lower or upper) and we can be more precise telling it's only the letter to find that will be in lower/uppercase (the words won't be affected by this setting). | |
152 | you should only reload the level on onSaveData where you need to store the value | |
src/activities/letter-in-word/letter-in-word.js | ||
121 ↗ | (On Diff #23987) | if I'm not wrong (I didn't tested), there is a global configuration option to set all the texts in uppercase. |
src/activities/letter-in-word/LetterInWord.qml | ||
---|---|---|
69 | why don't you directly use the string value (not the text displayed, but a value associated to the combobox text)? It will be more explicit when used than the index | |
70 | as it is only used in the combobox (and not in the js file), it is better to declare it in the combobox |
src/activities/letter-in-word/LetterInWord.qml | ||
---|---|---|
26 | There is an enum in http://doc.qt.io/qt-5/qml-font.html for the capitalization, it would be better to use them than magic numbers (check the other parts of the code using it too). |
Sorry for delay, there is still an issue with mixed case
src/activities/letter-in-word/LetterInWord.qml | ||
---|---|---|
69 | The default value should be the same as ApplicationSettings.fontCapitalization | |
293 | after testing, it does not work as expected for MixedCase. |
https://phabricator.kde.org/D9360?vs=24711&id=29171&whitespace=ignore-most#toc
the letterCaseBox model changed again from enum values (good) to magic numbers (not good)
Committed in https://commits.kde.org/gcompris/7c769594a5372e560904511404e2d1e156904050
don't hesitate to check if it works fine,
thank you