Instead of using implicit casts, use the ones we need as suggested for KF5.
Details
Details
Diff Detail
Diff Detail
- Repository
- R302 KIconThemes
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Looks already pretty just. I just stumbled over two issues which maybe should be clarified - see comments.
src/kiconeffect.cpp | ||
---|---|---|
163 | This should be: or do I miss something? | |
165 | Previously, this was not an else if(), but just an if(). Are you sure this works as intended? |
Comment Actions
Thanks!
src/kiconeffect.cpp | ||
---|---|---|
165 | Yes, effectGroupState is not going to change values out of the blue. |
Comment Actions
:( when I rebased to current master I realized that @mlaurent worked on a very similar patch without going through review (which btw is policy in KDE Frameworks).
*pouts*