Deprecate Kirigami.Label
ClosedPublic

Authored by davidedmundson on Oct 3 2017, 11:56 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R169:72c01208fe79: Deprecate Kirigami.Label
Summary

QQC2 Styles style labels themselves, we don't to do this via a
subclass.

This is a relic from Kirigami 1 where labels were not themed, and whilst
it makes some sense for source compatibility, encouraging its use does
not; Both the gallery and systemsettings already has a weird mix of both going on.

This patch also adjusts documentation that talks about Plasma styles;
which I think is a copy-paste error.

Test Plan

Ran gallery and system settings
Looks the same

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Oct 3 2017, 11:56 PM
Restricted Application added projects: Plasma, Kirigami. · View Herald TranscriptOct 3 2017, 11:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Oct 4 2017, 9:49 AM
mart added inline comments.
src/controls/Label.qml
42

in order to make it very explicit that's deprecated, i would like a print in component.oncompleted warning not to use it

Can do.
Will be a bit noisy as if it's used in a delegate it'll be spewing out constantly.

mart added a comment.Oct 4 2017, 10:11 AM

Can do.
Will be a bit noisy as if it's used in a delegate it'll be spewing out constantly.

i'm ok with the noise... helps people actually wanting to do the port ;)

mart accepted this revision.Oct 4 2017, 10:43 AM
This revision is now accepted and ready to land.Oct 4 2017, 10:43 AM
This revision was automatically updated to reflect the committed changes.