Updates for move tool
ClosedPublic

Authored by abrahams on Jan 6 2016, 12:35 AM.

Details

Reviewers
rempt
Group Reviewers
Krita
Maniphest Tasks
Restricted Maniphest Task
Commits
R37:483379eea66a: Updates for move tool
Summary

Allow setting different units of measurement.

Diff Detail

Repository
R37 Krita
Branch
movetool (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
abrahams updated this revision to Diff 1754.Jan 6 2016, 12:35 AM
abrahams retitled this revision from to Updates for move tool.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added a reviewer: Krita.
abrahams added a task: Restricted Maniphest Task.
abrahams updated this revision to Diff 1755.EditedJan 6 2016, 3:25 AM

Allow setting different units of measurement

abrahams updated this object.Jan 6 2016, 3:51 AM
rempt accepted this revision.Jan 6 2016, 10:06 AM
rempt added a reviewer: rempt.
rempt added a subscriber: rempt.

Lovely! One remark/todo left: the move tool should remember the settings across sessions, and it probably should still be set to pixels by default.

This revision is now accepted and ready to land.Jan 6 2016, 10:06 AM
This revision was automatically updated to reflect the committed changes.

Cool! The step size does get saved, and the tool remembers the previously selected unit as well. I think that may be nicer than resetting to pixels each time.

rempt added a comment.Jan 6 2016, 1:20 PM

Okay -- I checked this morning, and it didn't remember the settings (yet)? I agree that the chosen unit needs to be kept, it just should be pixel by default, before the user has chosen anything.