API: Add more enum classes
ClosedPublic
Actions

Authored by staniek on Jul 17 2017, 5:46 PM.

Details

Reviewers

piggz

Commits

R14:fc57429bc1d9: API: Add more enum classes

Summary

Add more enum classes.

FIXED-IN:3.1.0

Test Plan

Build KReport with tests enabled, run tests, run KReportExample.

Repository

R14 KReport

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision was automatically updated to reflect the committed changes.

Some more qustions @piggz ...

src/common/KReportDocument.cpp
196	@piggz Change in logic but unsure here. Don't we want to iterate until PageFooterAny here?
241	Same question here - PageFooterAny?
src/wrtembed/KReportDesigner.cpp
1224	Same question here - PageFooterAny?
1268	Same question here - GroupFooter ?

src/common/KReportDocument.cpp
196	GroupFooter is the last section type in the enum.....but yes, section() doesnt handle Group* sections anyway, so will ignore the last 2.
241	Yes, section() will ignore Group* sections anyway.
src/wrtembed/KReportDesigner.cpp
1224	yes, should be fixed.
1268	yes, should be fixed.

			Path	Packages
M			autotests/ElementsTest.cpp (8 lines)
M			autotests/format/FormatTest.cpp (6 lines)
M			src/common/KReportDesign.cpp (6 lines)
M			src/common/KReportDesign_p.h (2 lines)
M			src/common/KReportDesign_p.cpp (49 lines)
M			src/common/KReportDocument.h (6 lines)
M			src/common/KReportDocument.cpp (65 lines)
M			src/common/KReportRenderObjects.h (8 lines)
M			src/common/KReportRenderObjects.cpp (12 lines)
M			src/common/KReportSection.shared.h (10 lines)
M			src/common/KReportSectionData.h (14 lines)
M			src/common/KReportSectionData.cpp (76 lines)
M			src/items/check/KReportItemCheck.cpp (6 lines)
M			src/renderer/KReportHTMLCSSRenderer_p.cpp (22 lines)
M			src/renderer/KReportHTMLTableRenderer_p.cpp (22 lines)
M			src/renderer/KReportPrintRenderer_p.cpp (4 lines)
M			src/renderer/KReportScreenRenderer_p.cpp (4 lines)
M			src/renderer/scripting/KReportScriptConstants.h (2 lines)
M			src/wrtembed/KReportDesigner.h (6 lines)
M			src/wrtembed/KReportDesigner.cpp (172 lines)
M			src/wrtembed/KReportDesignerItemRectBase.h (8 lines)
M			src/wrtembed/KReportDesignerItemRectBase.cpp (12 lines)
M			src/wrtembed/KReportRuler_p.cpp (86 lines)
M			src/wrtembed/KReportSectionEditor.cpp (72 lines)
M			src/wrtembed/KReportZoomHandler_p.h (13 lines)
M			src/wrtembed/KReportZoomHandler_p.cpp (4 lines)
M			src/wrtembed/KReportZoomMode_p.h (38 lines)
M			src/wrtembed/KReportZoomMode_p.cpp (58 lines)