API: Add more enum classes

Authored by staniek on Jul 17 2017, 5:43 PM.

Description

API: Add more enum classes

Summary:
Add more enum classes.

FIXED-IN:3.1.0

Test Plan: Build KReport with tests enabled, run tests, run KReportExample.

Reviewers: piggz

Tags: KReport

Differential Revision: https://phabricator.kde.org/D6758

Details

Auditors
piggz
Committed
staniekJul 17 2017, 6:05 PM
Differential Revision
D6758: API: Add more enum classes
Parents
R14:5ac90cb31752: Make page break related enums in KReportDetailSectionData and…
Branches
Unknown
Tags
Unknown
staniek added a project: KReport.
This commit now requires audit.Jul 17 2017, 6:08 PM
staniek removed an auditor: piggz.Jul 17 2017, 6:12 PM
staniek added a subscriber: piggz.
staniek added inline comments.
/src/common/KReportDocument.cpp
196

@piggz Change in logic here and I am unsure: don't we want to iterate until GroupFooter instead of PageFooterAny?

(planned to ask before pushing first, sorry)

241

@piggz Change in logic here and I am unsure: don't we want to iterate until GroupFooter instead of PageFooterAny == 12?

/src/wrtembed/KReportDesigner.cpp
420

Same question here...

1224

Same question here...

1268

Same question here...

This commit no longer requires audit.Jul 17 2017, 6:12 PM
staniek added an auditor: piggz.
This commit now requires audit.Jul 17 2017, 6:16 PM
piggz raised a concern with this commit.Jul 17 2017, 7:43 PM
piggz added inline comments.
/src/common/KReportDocument.cpp
196

Actually no, im not sure this is correct. GroupHeader/Footer are different in that there can be many of these. If you check the code which returns the section(), they dont handle groups.

This commit now has outstanding concerns.Jul 17 2017, 7:43 PM
staniek requested verification of this commit.Jul 18 2017, 10:57 AM
This commit now requires verification by auditors.Jul 18 2017, 10:57 AM
piggz accepted this commit.Jul 22 2017, 8:19 AM
All concerns with this commit have now been addressed.Jul 22 2017, 8:19 AM