Differential D635

Don't make lots of native windows
ClosedPublic
Actions

Authored by abrahams on Dec 7 2015, 1:16 AM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:46bd59244c10: Don't make lots of native windows
Summary

I'm not sure whether this has any material impact.

http://blog.qt.io/blog/2007/08/09/qt-invaded-by-aliens-the-end-of-all-flicker/

Diff Detail

Repository
R37 Krita
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
abrahams updated this revision to Diff 1461.Dec 7 2015, 1:16 AM
abrahams retitled this revision from to Don't make lots of native windows.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added a reviewer: rempt.
Closed by commit R37:46bd59244c10: Don't make lots of native windows (authored by abrahams). · Explain WhyDec 10 2015, 3:30 PM
This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 121 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathPackages
Mkrita/image/tests/kis_random_generator_demo.ui (16 lines)
Mkrita/plugins/extensions/bigbrother/actionseditor/wdgactionseditor.ui (2 lines)
Mkrita/plugins/extensions/colorspaceconversion/wdgconvertcolorspace.ui (2 lines)
Mkrita/plugins/extensions/dockers/advancedcolorselector/wdg_color_selector_settings.ui (4 lines)
Mkrita/plugins/extensions/dockers/animation/onion_skins_docker.ui (2 lines)
Mkrita/plugins/extensions/dockers/artisticcolorselector/forms/wdgArtisticColorSelector.ui (2 lines)
Mkrita/plugins/extensions/dockers/artisticcolorselector/forms/wdgColorPreferencesPopup.ui (6 lines)
Mkrita/plugins/extensions/dockers/defaultdockers/wdglayerbox.ui (4 lines)
Mkrita/plugins/extensions/dockers/imagedocker/forms/wdgImageViewPopup.ui (2 lines)
Mkrita/plugins/extensions/dockers/lut/wdglut.ui (4 lines)
Mkrita/plugins/extensions/dockers/tasksetdocker/wdgtasksetdocker.ui (2 lines)
Mkrita/plugins/extensions/gmic/wdg_gmic.ui (2 lines)
Mkrita/plugins/extensions/gmic/wdg_gmic_input_output.ui (2 lines)
Mkrita/plugins/extensions/histogram/wdghistogram.ui (2 lines)
Mkrita/plugins/extensions/imagesize/wdg_canvassize.ui (4 lines)
Mkrita/plugins/extensions/imagesize/wdg_imagesize.ui (6 lines)
Mkrita/plugins/extensions/imagesize/wdg_layersize.ui (4 lines)
Mkrita/plugins/extensions/layersplit/wdg_layersplit.ui (2 lines)
Mkrita/plugins/extensions/resourcemanager/wdgdlgbundlemanager.ui (4 lines)
Mkrita/plugins/extensions/resourcemanager/wdgdlgcreatebundle.ui (4 lines)
Mkrita/plugins/extensions/shearimage/wdg_shearimage.ui (4 lines)
Mkrita/plugins/filters/blur/wdg_gaussian_blur.ui (6 lines)
Mkrita/plugins/filters/blur/wdgblur.ui (2 lines)
Mkrita/plugins/filters/colors/wdgcolortoalphabase.ui (4 lines)
Mkrita/plugins/filters/colorsfilters/wdg_brightness_contrast.ui (2 lines)
Mkrita/plugins/filters/colorsfilters/wdg_hsv_adjustment.ui (6 lines)
Mkrita/plugins/filters/colorsfilters/wdg_perchannel.ui (2 lines)
Mkrita/plugins/filters/fastcolortransfer/wdgfastcolortransfer.ui (2 lines)
Mkrita/plugins/filters/indexcolors/kiswdgindexcolors.ui (4 lines)
Mkrita/plugins/filters/levelfilter/wdg_level.ui (4 lines)
Mkrita/plugins/filters/phongbumpmap/wdgphongbumpmap.ui (8 lines)
Mkrita/plugins/formats/jpeg/kis_wdg_options_jpeg.ui (4 lines)
Mkrita/plugins/formats/pdf/pdfimportwidgetbase.ui (2 lines)
Mkrita/plugins/formats/png/kis_wdg_options_png.ui (2 lines)
Mkrita/plugins/formats/raw/wdgrawimport.ui (2 lines)
Mkrita/plugins/generators/pattern/wdgpatternoptions.ui (2 lines)
Mkrita/plugins/paintops/chalk/wdgchalkoptions.ui (2 lines)
Mkrita/plugins/paintops/curvebrush/wdgcurveoptions.ui (6 lines)
Mkrita/plugins/paintops/deform/wdgdeformoptions.ui (2 lines)
Mkrita/plugins/paintops/dynadraw/wdgdynaoptions.ui (4 lines)
Mkrita/plugins/paintops/experiment/wdgexperimentoptions.ui (6 lines)
Mkrita/plugins/paintops/gridbrush/wdggridoptions.ui (10 lines)
Mkrita/plugins/paintops/hairy/wdgInkOptions.ui (10 lines)
Mkrita/plugins/paintops/hairy/wdgbristleoptions.ui (8 lines)
Mkrita/plugins/paintops/hairy/wdghairyeoptions.ui (2 lines)
Mkrita/plugins/paintops/hatching/wdghatchingoptions.ui (10 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgBrushSizeOptions.ui (14 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgairbrush.ui (2 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgautobrush.ui (22 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgbrushchooser.ui (2 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgclipboardbrush.ui (2 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgcoloroptions.ui (6 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgcurveoption.ui (6 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgcustombrush.ui (2 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgflowopacityoption.ui (6 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgmultisensorsselector.ui (2 lines)
Mkrita/plugins/paintops/libpaintop/forms/wdgtextbrush.ui (2 lines)
Mkrita/plugins/paintops/libpaintop/sensors/SensorDistanceConfiguration.ui (2 lines)
Mkrita/plugins/paintops/libpaintop/sensors/SensorFadeConfiguration.ui (2 lines)
Mkrita/plugins/paintops/libpaintop/sensors/SensorTimeConfiguration.ui (2 lines)
Mkrita/plugins/paintops/particle/wdgparticleoptions.ui (10 lines)
Mkrita/plugins/paintops/sketch/wdgsketchoptions.ui (4 lines)
Mkrita/plugins/paintops/spray/wdgshapedynamicsoptions.ui (4 lines)
Mkrita/plugins/paintops/spray/wdgsprayoptions.ui (16 lines)
Mkrita/plugins/paintops/spray/wdgsprayshapeoptions.ui (6 lines)
Mkrita/plugins/paintops/tangentnormal/wdgtangenttiltoption.ui (4 lines)
Mkrita/plugins/tools/defaulttools/wdgmovetool.ui (2 lines)
Mkrita/plugins/tools/tool_crop/wdg_tool_crop.ui (2 lines)
Mkrita/plugins/tools/tool_text/wdgtextoptions.ui (2 lines)
Mkrita/plugins/tools/tool_transform2/wdg_tool_transform.ui (38 lines)
Mkrita/ui/forms/kis_previewwidgetbase.ui (2 lines)
Mkrita/ui/forms/wdgautogradient.ui (2 lines)
Mkrita/ui/forms/wdgcolorsettings.ui (2 lines)
Mkrita/ui/forms/wdgcolorspaceselectoradvanced.ui (2 lines)
Mkrita/ui/forms/wdgdlgfilelayer.ui (2 lines)
Mkrita/ui/forms/wdgdlggeneratorlayer.ui (2 lines)
Mkrita/ui/forms/wdgfilterdialog.ui (2 lines)
Mkrita/ui/forms/wdgfilternodecreation.ui (4 lines)
Mkrita/ui/forms/wdgfilterselector.ui (6 lines)
Mkrita/ui/forms/wdggenerators.ui (2 lines)
Mkrita/ui/forms/wdggridsettings.ui (4 lines)
Mkrita/ui/forms/wdgimageproperties.ui (2 lines)
Mkrita/ui/forms/wdglayerproperties.ui (2 lines)
Mkrita/ui/forms/wdgmultipliersdoublesliderspinbox.ui (2 lines)
Mkrita/ui/forms/wdgnewimage.ui (4 lines)
Mkrita/ui/forms/wdgpaintactioneditor.ui (6 lines)
Mkrita/ui/forms/wdgpaintoppresets.ui (2 lines)
Mkrita/ui/forms/wdgpaintopsettings.ui (8 lines)
Mkrita/ui/forms/wdgperformancesettings.ui (8 lines)
Mkrita/ui/forms/wdgpresetselectorstrip.ui (2 lines)
Mkrita/ui/forms/wdgtabletsettings.ui (2 lines)
Mkrita/ui/layerstyles/WdgColorOverlay.ui (2 lines)
Mkrita/ui/layerstyles/WdgGradientOverlay.ui (4 lines)
Mkrita/ui/layerstyles/WdgPatternOverlay.ui (4 lines)
Mkrita/ui/layerstyles/WdgSatin.ui (8 lines)
Mkrita/ui/layerstyles/WdgStroke.ui (8 lines)
Mkrita/ui/layerstyles/wdgBevelAndEmboss.ui (10 lines)
Mkrita/ui/layerstyles/wdgContour.ui (4 lines)
Mkrita/ui/layerstyles/wdgInnerGlow.ui (14 lines)
Mkrita/ui/layerstyles/wdgTexture.ui (4 lines)
Mkrita/ui/layerstyles/wdgblendingoptions.ui (8 lines)
Mkrita/ui/layerstyles/wdgdropshadow.ui (12 lines)
Mlibs/flake/KoConnectionShapeConfigWidget.ui (2 lines)
Mlibs/flake/SnapGuideConfigWidget.ui (2 lines)
Mlibs/flake/tools/PathToolOptionWidgetBase.ui (2 lines)
Mlibs/widgets/KoShadowConfigWidget.ui (2 lines)
Mplugins/defaultTools/connectionTool/ConnectionPointWidget.ui (2 lines)
Mplugins/defaultTools/defaulttool/DefaultToolArrangeWidget.ui (2 lines)
Mplugins/defaultTools/defaulttool/DefaultToolWidget.ui (4 lines)
Mplugins/textshape/dialogs/ParagraphBulletsNumbers.ui (2 lines)
Mplugins/textshape/dialogs/ParagraphDropCaps.ui (2 lines)
Mplugins/textshape/dialogs/SimpleAnnotationWidget.ui (2 lines)
Mplugins/textshape/dialogs/SimpleCharacterWidget.ui (2 lines)
Mplugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui (2 lines)
Mplugins/textshape/dialogs/SimpleFootEndNotesWidget.ui (2 lines)
Mplugins/textshape/dialogs/SimpleInsertWidget.ui (2 lines)
Mplugins/textshape/dialogs/SimpleLinksWidget.ui (2 lines)
Mplugins/textshape/dialogs/SimpleParagraphWidget.ui (2 lines)
Mplugins/textshape/dialogs/SimpleSpellCheckingWidget.ui (2 lines)
Mplugins/textshape/dialogs/SimpleTableOfContentsWidget.ui (2 lines)
Mplugins/textshape/dialogs/SimpleTableWidget.ui (2 lines)

Diff 1461

View Options

krita/image/tests/kis_random_generator_demo.ui

View Options

krita/plugins/extensions/bigbrother/actionseditor/wdgactionseditor.ui

View Options

krita/plugins/extensions/colorspaceconversion/wdgconvertcolorspace.ui

View Options

krita/plugins/extensions/dockers/advancedcolorselector/wdg_color_selector_settings.ui

View Options

krita/plugins/extensions/dockers/animation/onion_skins_docker.ui

View Options

krita/plugins/extensions/dockers/artisticcolorselector/forms/wdgArtisticColorSelector.ui

View Options

krita/plugins/extensions/dockers/artisticcolorselector/forms/wdgColorPreferencesPopup.ui

View Options

krita/plugins/extensions/dockers/defaultdockers/wdglayerbox.ui

View Options

krita/plugins/extensions/dockers/imagedocker/forms/wdgImageViewPopup.ui

View Options

krita/plugins/extensions/dockers/lut/wdglut.ui

View Options

krita/plugins/extensions/dockers/tasksetdocker/wdgtasksetdocker.ui

View Options

krita/plugins/extensions/gmic/wdg_gmic.ui

View Options

krita/plugins/extensions/gmic/wdg_gmic_input_output.ui

View Options

krita/plugins/extensions/histogram/wdghistogram.ui

View Options

krita/plugins/extensions/imagesize/wdg_canvassize.ui

View Options

krita/plugins/extensions/imagesize/wdg_imagesize.ui

View Options

krita/plugins/extensions/imagesize/wdg_layersize.ui

View Options

krita/plugins/extensions/layersplit/wdg_layersplit.ui

View Options

krita/plugins/extensions/resourcemanager/wdgdlgbundlemanager.ui

View Options

krita/plugins/extensions/resourcemanager/wdgdlgcreatebundle.ui

View Options

krita/plugins/extensions/shearimage/wdg_shearimage.ui

View Options

krita/plugins/filters/blur/wdg_gaussian_blur.ui

View Options

krita/plugins/filters/blur/wdgblur.ui

View Options

krita/plugins/filters/colors/wdgcolortoalphabase.ui

View Options

krita/plugins/filters/colorsfilters/wdg_brightness_contrast.ui

View Options

krita/plugins/filters/colorsfilters/wdg_hsv_adjustment.ui

View Options

krita/plugins/filters/colorsfilters/wdg_perchannel.ui

View Options

krita/plugins/filters/fastcolortransfer/wdgfastcolortransfer.ui

View Options

krita/plugins/filters/indexcolors/kiswdgindexcolors.ui

View Options

krita/plugins/filters/levelfilter/wdg_level.ui

View Options

krita/plugins/filters/phongbumpmap/wdgphongbumpmap.ui

View Options

krita/plugins/formats/jpeg/kis_wdg_options_jpeg.ui

View Options

krita/plugins/formats/pdf/pdfimportwidgetbase.ui

View Options

krita/plugins/formats/png/kis_wdg_options_png.ui

View Options

krita/plugins/formats/raw/wdgrawimport.ui

View Options

krita/plugins/generators/pattern/wdgpatternoptions.ui

View Options

krita/plugins/paintops/chalk/wdgchalkoptions.ui

View Options

krita/plugins/paintops/curvebrush/wdgcurveoptions.ui

View Options

krita/plugins/paintops/deform/wdgdeformoptions.ui

View Options

krita/plugins/paintops/dynadraw/wdgdynaoptions.ui

View Options

krita/plugins/paintops/experiment/wdgexperimentoptions.ui

View Options

krita/plugins/paintops/gridbrush/wdggridoptions.ui

View Options

krita/plugins/paintops/hairy/wdgInkOptions.ui

View Options

krita/plugins/paintops/hairy/wdgbristleoptions.ui

View Options

krita/plugins/paintops/hairy/wdghairyeoptions.ui

View Options

krita/plugins/paintops/hatching/wdghatchingoptions.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgBrushSizeOptions.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgairbrush.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgautobrush.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgbrushchooser.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgclipboardbrush.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgcoloroptions.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgcurveoption.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgcustombrush.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgflowopacityoption.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgmultisensorsselector.ui

View Options

krita/plugins/paintops/libpaintop/forms/wdgtextbrush.ui

View Options

krita/plugins/paintops/libpaintop/sensors/SensorDistanceConfiguration.ui

View Options

krita/plugins/paintops/libpaintop/sensors/SensorFadeConfiguration.ui

View Options

krita/plugins/paintops/libpaintop/sensors/SensorTimeConfiguration.ui

View Options

krita/plugins/paintops/particle/wdgparticleoptions.ui

View Options

krita/plugins/paintops/sketch/wdgsketchoptions.ui

View Options

krita/plugins/paintops/spray/wdgshapedynamicsoptions.ui

View Options

krita/plugins/paintops/spray/wdgsprayoptions.ui

View Options

krita/plugins/paintops/spray/wdgsprayshapeoptions.ui

View Options

krita/plugins/paintops/tangentnormal/wdgtangenttiltoption.ui

View Options

krita/plugins/tools/defaulttools/wdgmovetool.ui

View Options

krita/plugins/tools/tool_crop/wdg_tool_crop.ui

View Options

krita/plugins/tools/tool_text/wdgtextoptions.ui

View Options

krita/plugins/tools/tool_transform2/wdg_tool_transform.ui

View Options

krita/ui/forms/kis_previewwidgetbase.ui

View Options

krita/ui/forms/wdgautogradient.ui

View Options

krita/ui/forms/wdgcolorsettings.ui

View Options

krita/ui/forms/wdgcolorspaceselectoradvanced.ui

View Options

krita/ui/forms/wdgdlgfilelayer.ui

View Options

krita/ui/forms/wdgdlggeneratorlayer.ui

View Options

krita/ui/forms/wdgfilterdialog.ui

View Options

krita/ui/forms/wdgfilternodecreation.ui

View Options

krita/ui/forms/wdgfilterselector.ui

View Options

krita/ui/forms/wdggenerators.ui

View Options

krita/ui/forms/wdggridsettings.ui

View Options

krita/ui/forms/wdgimageproperties.ui

View Options

krita/ui/forms/wdglayerproperties.ui

View Options

krita/ui/forms/wdgmultipliersdoublesliderspinbox.ui

View Options

krita/ui/forms/wdgnewimage.ui

View Options

krita/ui/forms/wdgpaintactioneditor.ui

View Options

krita/ui/forms/wdgpaintoppresets.ui

View Options

krita/ui/forms/wdgpaintopsettings.ui

View Options

krita/ui/forms/wdgperformancesettings.ui

View Options

krita/ui/forms/wdgpresetselectorstrip.ui

View Options

krita/ui/forms/wdgtabletsettings.ui

View Options

krita/ui/layerstyles/WdgColorOverlay.ui

View Options

krita/ui/layerstyles/WdgGradientOverlay.ui

View Options

krita/ui/layerstyles/WdgPatternOverlay.ui

View Options

krita/ui/layerstyles/WdgSatin.ui

View Options

krita/ui/layerstyles/WdgStroke.ui

View Options

krita/ui/layerstyles/wdgBevelAndEmboss.ui

View Options

krita/ui/layerstyles/wdgContour.ui

View Options

krita/ui/layerstyles/wdgInnerGlow.ui

View Options

krita/ui/layerstyles/wdgTexture.ui

View Options

krita/ui/layerstyles/wdgblendingoptions.ui

View Options

krita/ui/layerstyles/wdgdropshadow.ui

View Options

libs/flake/KoConnectionShapeConfigWidget.ui

View Options

libs/flake/SnapGuideConfigWidget.ui

View Options

libs/flake/tools/PathToolOptionWidgetBase.ui

View Options

libs/widgets/KoShadowConfigWidget.ui

View Options

plugins/defaultTools/connectionTool/ConnectionPointWidget.ui

View Options

plugins/defaultTools/defaulttool/DefaultToolArrangeWidget.ui

View Options

plugins/defaultTools/defaulttool/DefaultToolWidget.ui

View Options

plugins/textshape/dialogs/ParagraphBulletsNumbers.ui

View Options

plugins/textshape/dialogs/ParagraphDropCaps.ui

View Options

plugins/textshape/dialogs/SimpleAnnotationWidget.ui

View Options

plugins/textshape/dialogs/SimpleCharacterWidget.ui

View Options

plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui

View Options

plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui

View Options

plugins/textshape/dialogs/SimpleInsertWidget.ui

View Options

plugins/textshape/dialogs/SimpleLinksWidget.ui

View Options

plugins/textshape/dialogs/SimpleParagraphWidget.ui

View Options

plugins/textshape/dialogs/SimpleSpellCheckingWidget.ui

View Options

plugins/textshape/dialogs/SimpleTableOfContentsWidget.ui

View Options

plugins/textshape/dialogs/SimpleTableWidget.ui