Differential D5869

Fix crash when renaming top-level entries
ClosedPublic
Actions

Authored by elvisangelaccio on May 15 2017, 3:55 PM.

Details

Reviewers
rthomsen
Commits
R36:ed46c0d66e82: Fix crash when renaming top-level entries
Summary

After commit 7781d6ef79, the model of the archive view changed to the
filter model. So we were asking m_model to get an index from
currentIndex, which instead belongs to m_filterModel.
The returned index was invalid and this caused a crash in the view.

BUG: 379802
FIXED-IN: 17.04.2

Test Plan

Renaming top-level entries doesn't crash anymore. Renaming child entries still works.

Diff Detail

Repository
R36 Ark
Branch
bug/379802 (branched from Applications/17.04)
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Ark. · View Herald TranscriptMay 15 2017, 3:55 PM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
elvisangelaccio updated this revision to Diff 14557.May 15 2017, 4:03 PM
  • Turns out there is a reason for the old code, it makes sure that only the first column can be edited.
elvisangelaccio edited the summary of this revision. (Show Details)May 15 2017, 4:06 PM
Closed by commit R36:ed46c0d66e82: Fix crash when renaming top-level entries (authored by elvisangelaccio). · Explain WhyJun 1 2017, 9:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 14557

View Options

autotests/kerfuffle/data/simplearchive.tar.gz

Loading...
View Options

part/part.cpp

Loading...