This implments
T3499 Layer thumbnail on the timeline on hover
It also fixes the tooltip used for e.g. the brush to show the brush in the tooltip
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Hi, @zachmann!
I have tested your patch. Basically it works correctly, but there is one issue and one wish:
- Issue. With your patch you cannot start Ctrl+Drag&Drop operation anymore. I don't know why it happens. Most probably, because the widget loses its focus after Ctrl is pressed.
- Wish: it would also be nice if the tool tip would have some additional information about the frame:
Layer1 Frame: 23 Duration: 20-29
Or something like that.
@timotheegiet hi! Could you please recommend something about what info about the frame should be available in the tooltip?
| plugins/dockers/animation/timeline_frames_view.cpp | ||
|---|---|---|
| 931 | It's this bit that's the problem. I'm not sure what it's going to do, but without it, the tooltips still work fine on hover? | |
| plugins/dockers/animation/timeline_frames_view.cpp | ||
|---|---|---|
| 931 | Without any modifier, it is extremely difficult to get a tooltip with a stylus, because stylus always moves. So ideally we should use KiAdditionalModifiersCatcher for this... | |
Comment Actions
Just a note to say, from a tablet user experience: tooltips are not that difficult to see with a stylus, just move the stylus away from the tablet detection to make it stop moving. I use it very often.
Also, isn't it the same for all tooltip we have now, including the layer thumbnails? Why would we need a special shortcut for this kind of tooltip specifically?
Comment Actions
Patch without special handling for stylus.
Can people with a stylus please test to see if the tooltips still work for them with the reduces functionality
I would prefer it this way as it makes the code much simpler
Comment Actions
Hi, @timotheegiet, @rempt, @zachmann !
The difference between the layer box and the timeline is that the number of different thumbnails in the timeline is much higher. The main idea of this feature was to replace the feature of TVPaint, where the contents of the frames is visible right in the timeline itself. According to the input of animators (the ones I was talking to), this feature is extremely useful when you have a lot of layers with a lot of frames: just a single glance is enough to locate where the needed frame is.
So the main usecase can be formulated like this: "Let the user visually locate the needed frame, when he doesn't know where it is"
As a result, the reason for the proposed special shortcut is: you can just hover over the frames and see the content of the frames in the realtime, without any delay. Obviously enough, usual tool-tip event, which is shown after a delay, won't solve the usecase.
How about an alternative solution: we don't add any shortcut, but we use hover with middle-button pressed for showing the tooltip? This shortcut is not yet used in the timeline and will not break D&D. It is not as obvious and configurable as a shortcut, but it would at least somehow solve the usecase...
PS:
Although, speaking truly, I cannot understand, what is the problem of using KisCustomModifiersCatcher for the purpose. It is already used inside the timeline, so adapting it for the task should be a matter of a dozen of lines of code.
Comment Actions
what is the problem of using KisCustomModifiersCatcher for the purpose.
Well, one problem is that it's yet another completely undocumented utility class. It's not clear how to use it, when to use or why to use it.
Comment Actions
Hi, @boud!
This class has only two methods with obvious names and already used in the timeline for the same purpose. Anyway, I've pushed a patch with the docs, so now there is no excuse for not using a shortcut :)
https://commits.kde.org/krita/87cdf0efb5f49156a94cdafa3717cb1e4dc03a82
Comment Actions
Here the patch using middle button for showing the tooltip.
@dkazakov : I will implement showing the additional information once this patch is in as it needs again changes in the lib