Differential D4093

Initialise array variable
AbandonedPublic
Actions

Authored by davidedmundson on Jan 12 2017, 12:12 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Summary

Some code later calls cachedRectangleSelection.length which gives a
warning.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 10080.Jan 12 2017, 12:12 AM
davidedmundson retitled this revision from to Initialise array variable.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 12 2017, 12:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein requested changes to this revision.Jan 12 2017, 7:47 AM
hein added a reviewer: hein.
hein added a subscriber: hein.

Hmm, weird. I remember seeing that warning and changing the condition to cachedRectangleSelection && cachedRectangleSelection.length, but somehow it didn't end up in git.

If you go with [] here, you also need to change line 364.

This revision now requires changes to proceed.Jan 12 2017, 7:47 AM
davidedmundson abandoned this revision.Jan 16 2017, 10:58 AM

Revision Contents
Changeset List

Diff 10080

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...