Differential D11599 Diff 32248 src/QuickEditor/EditorRoot.qml

Changeset View

Standalone View

View Options

src/QuickEditor/EditorRoot.qml

Show All 23 Lines23Item {
24 id: editorRoot; 24​ id: editorRoot;
25 objectName: "editorRoot"; 25​ objectName: "editorRoot";
26 26​
27 // properties and setters 27​ // properties and setters
28 28​
29 property var selection: undefined; 29​ property var selection: undefined;
30 property color maskColour: Qt.rgba(0, 0, 0, 0.15); 30​ property color maskColour: Qt.rgba(0, 0, 0, 0.15);
31 property color strokeColour: Qt.rgba(0.114, 0.6, 0.953, 1); 31​ property color strokeColour: Qt.rgba(0.114, 0.6, 0.953, 1);
32​ property color crossColour: Qt.rgba(0.114, 0.6, 0.953, 0.5);
33​ property bool showMagnifier: false;
34​ property var magZoom: 5;
35​ property var magPixels: 16;
36​ property var magOffset: 32;
alexeyminUnsubmitted
Done

can these magZoom, magPixels, magOffset have type int instead of var? Just asking, why var?

alexeymin: can these `magZoom`, `magPixels`, `magOffset` have type `int` instead of `var`? Just asking…
37​
32 SystemPalette { 38​ SystemPalette {
33 id: systemPalette; 39​ id: systemPalette;
34 } 40​ }
35 41​
36 function setInitialSelection(xx, yy, ww, hh) { 42​ function setInitialSelection(xx, yy, ww, hh) {
37 if (selection) { 43​ if (selection) {
38 selection.destroy(); 44​ selection.destroy();
39 } 45​ }
40 46​
41 selection = cropRectangle.createObject(parent, { 47​ selection = cropRectangle.createObject(parent, {
42 "x": xx, 48​ "x": xx,
43 "y": yy, 49​ "y": yy,
44 "height": hh, 50​ "height": hh,
45 "width": ww 51​ "width": ww
46 }); 52​ });
47 53​
48 cropDisplayCanvas.requestPaint(); 54​ cropDisplayCanvas.requestPaint();
49 } 55​ }
50 56​
57​ function setShowMagnifier() {
58​ showMagnifier = true;
59​ }
60​
alexeyminUnsubmitted
Done

This function setShowMagnifier() is probably not needed at all. You can set context property directly from C++, without invokeMethod, see below

alexeymin: This function `setShowMagnifier()` is probably not needed at all. You can set context property…
51 function accept() { 61​ function accept() {
52 if (selection) { 62​ if (selection) {
53 acceptImage(selection.x, selection.y, selection.width, selection.height); 63​ acceptImage(selection.x, selection.y, selection.width, selection.height);
54 } else { 64​ } else {
55 acceptImage(-1, -1, -1, -1); 65​ acceptImage(-1, -1, -1, -1);
56 } 66​ }
57 } 67​ }
58 68​
59 // key handlers 69​ // key handlers
60 70​
61 focus: true; 71​ focus: true;
62 72​
63 Keys.onReturnPressed: accept() 73​ Keys.onReturnPressed: accept()
64 Keys.onEnterPressed: accept() 74​ Keys.onEnterPressed: accept()
65 75​
66 Keys.onEscapePressed: { 76​ Keys.onEscapePressed: {
67 cancelImage(); 77​ cancelImage();
68 } 78​ }
69 79​
70 // signals 80​ // signals
71 81​
rkflxUnsubmitted
Done

For me this triggers for every key on the keyboard. Could you make it so that only ⇧+Alt+Ctrl affect the magnifier?

rkflx: For me this triggers for every key on the keyboard. Could you make it so that only {key Shift…
guotaoAuthorUnsubmitted
Done

my bad, wrong logic

guotao: my bad, wrong logic
72 signal acceptImage(int x, int y, int width, int height); 82​ signal acceptImage(int x, int y, int width, int height);
73 signal cancelImage(); 83​ signal cancelImage();
74 84​
75 Image { 85​ Image {
76 id: imageBackground; 86​ id: imageBackground;
77 objectName: "imageBackground"; 87​ objectName: "imageBackground";
78 88​
79 source: "image://snapshot/rawimage"; 89​ source: "image://snapshot/rawimage";
▲ Show 20 Lines • Show All 103 Lines • ▼ Show 20 Line(s)117 if (selection) {
183 } 193​ }
184 // Now do the actual box, border and text drawing 194​ // Now do the actual box, border and text drawing
185 ctx.fillStyle = systemPalette.window; 195​ ctx.fillStyle = systemPalette.window;
186 ctx.strokeStyle = systemPalette.windowText; 196​ ctx.strokeStyle = systemPalette.windowText;
187 ctx.fillRect(selectionBoxX - 4, selectionBoxY - selectionTextRect.height - 2, selectionTextRect.width + 10, selectionTextRect.height + 8); 197​ ctx.fillRect(selectionBoxX - 4, selectionBoxY - selectionTextRect.height - 2, selectionTextRect.width + 10, selectionTextRect.height + 8);
188 ctx.strokeRect(selectionBoxX - 4, selectionBoxY - selectionTextRect.height - 2, selectionTextRect.width + 10, selectionTextRect.height + 8); 198​ ctx.strokeRect(selectionBoxX - 4, selectionBoxY - selectionTextRect.height - 2, selectionTextRect.width + 10, selectionTextRect.height + 8);
189 ctx.fillStyle = systemPalette.windowText; 199​ ctx.fillStyle = systemPalette.windowText;
190 ctx.fillText(selectionText, selectionBoxX, selectionBoxY); 200​ ctx.fillText(selectionText, selectionBoxX, selectionBoxY);
201​ if (selection.zx >= 0 && selection.zy >= 0 && showMagnifier) {
202​ var offsetX = magOffset;
203​ var offsetY = magOffset;
204​ var magX = selection.zx;
205​ var magY = selection.zy;
206​ var magWidth = (magPixels * 2 + 1) * magZoom;
207​ var magHeight = (magPixels * 2 + 1) * magZoom;
ngrahamUnsubmitted
Done

Make all of these ints, please. vars are much slower.

ngraham: Make all of these `int`s, please. `var`s are much slower.
alexeyminUnsubmitted
Done

Javascript only has var type for variables. Not a property declaration here (

alexeymin: Javascript only has `var` type for variables. Not a property declaration here (
guotaoAuthorUnsubmitted
Done

@alexeymin, so it's doesn't need change here, right?

guotao: @alexeymin, so it's doesn't need change here, right?
alexeyminUnsubmitted
Done

Yes, in property declarations you can say property int x, property double y, but variable declarations inside JS code can only use var or let.

double offsetX

will produce unexpected token errors here.

alexeymin: Yes, in property declarations you can say `property int x`, `property double y`, but variable…
rkflxUnsubmitted
Done

You could be more DRY here:

var magWidth = crossMagnifier.width;
var magHeight = crossMagnifier.height;
rkflx: You could be more [DRY](https://en.wikipedia.org/wiki/Don't_repeat_yourself) here: ``` var…
208​
209​ if (magX + offsetX + magWidth >= Window.width / Screen.devicePixelRatio) {
210​ offsetX -= offsetX * 2 + magWidth;
211​ }
212​
213​ if (magY + offsetY + magHeight >= Window.height / Screen.devicePixelRatio) {
214​ offsetY -= offsetY * 2 + magHeight;
215​ }
216​
217​ magX += offsetX;
218​ magY += offsetY;
219​ crossMagnifier.visible = true;
220​ crossMagnifier.x = magX;
221​ crossMagnifier.y = magY;
222​ crossBackground.x = -selection.zx * Screen.devicePixelRatio * magZoom + magPixels * magZoom;
223​ crossBackground.y = -selection.zy * Screen.devicePixelRatio * magZoom + magPixels * magZoom;
224​ ctx.strokeRect(magX, magY, magWidth, magHeight);
225​ } else {
226​ crossMagnifier.visible = false;
227​ }
191 } else { 228​ } else {
192 midHelpText.visible = true; 229​ midHelpText.visible = true;
193 bottomHelpText.visible = false; 230​ bottomHelpText.visible = false;
231​ crossMagnifier.visible = false;
194 } 232​ }
195 } 233​ }
196 234​
197 TextMetrics { 235​ TextMetrics {
198 id: selectionTextMetrics 236​ id: selectionTextMetrics
199 } 237​ }
200 238​
201 Rectangle { 239​ Rectangle {
Show All 22 Lines261 Rectangle {
224 id: bottomHelpText; 262​ id: bottomHelpText;
225 objectName: "bottomHelpText"; 263​ objectName: "bottomHelpText";
226 264​
227 height: bottomHelpTextElement.height + 16; 265​ height: bottomHelpTextElement.height + 16;
228 width: bottomHelpTextElement.width + 24; 266​ width: bottomHelpTextElement.width + 24;
229 border.width: 1; 267​ border.width: 1;
230 border.color: Qt.rgba(0, 0, 0, 1); 268​ border.color: Qt.rgba(0, 0, 0, 1);
231 color: Qt.rgba(1, 1, 1, 0.85); 269​ color: Qt.rgba(1, 1, 1, 0.85);
270​ visible: false;
rkflxUnsubmitted
Done

Maybe there's a reason you have to add this, but currently I don't see it. Could you explain?

rkflx: Maybe there's a reason you have to add this, but currently I don't see it. Could you explain?
guotaoAuthorUnsubmitted
Done

I change this because the help text show and hide very quickly.
I think the default value should be false.

guotao: I change this because the help text show and hide very quickly. I think the default value…
rkflxUnsubmitted
Done

Ah, I see, makes sense. I was looking for an explanation connected to the magnifier, but apparently there is none to find ;)

Could you split out this change into a separate Diff, then? (Could even go to the Applications/18.04 branch, so users will get the fix earlier than the magnifier, which would have to wait until 18.08…)

rkflx: Ah, I see, makes sense. I was looking for an explanation connected to the magnifier, but…
232 271​
233 anchors.bottom: parent.bottom; 272​ anchors.bottom: parent.bottom;
234 anchors.horizontalCenter: parent.horizontalCenter; 273​ anchors.horizontalCenter: parent.horizontalCenter;
235 274​
236 Text { 275​ Text {
237 id: bottomHelpTextElement; 276​ id: bottomHelpTextElement;
238 text: i18n("To take the screenshot, double-click or press Enter. Right-click to reset the selection, or press Esc to quit"); 277​ text: i18n("To take the screenshot, double-click or press Enter. Right-click to reset the selection, or press Esc to quit");
239 font.pointSize: 9; 278​ font.pointSize: 9;
240 279​
241 anchors.centerIn: parent; 280​ anchors.centerIn: parent;
242 } 281​ }
243 } 282​ }
283​
284​ Rectangle {
285​ id: crossMagnifier;
286​ objectName: "crossMagnifier";
287​
288​ height: ( magPixels * 2 + 1) * magZoom;
289​ width: ( magPixels * 2 + 1) * magZoom;
rkflxUnsubmitted
Done

Why not use height here?

rkflx: Why not use `height` here?
guotaoAuthorUnsubmitted
Done

sorry, what you mean?

guotao: sorry, what you mean?
rkflxUnsubmitted
Done

You are duplicating the calculation for height also for width. As you simply want both to be the same, you could write:

width: height;
rkflx: You are duplicating the calculation for `height` also for `width`. As you simply want both to…
290​ border.width: 0;
291​ visible: false;
ngrahamUnsubmitted
Done

Instead of giving this poor Rectangle an invisible border and making it invisible, perhaps it should be a simple Item instead.

ngraham: Instead of giving this poor `Rectangle` an invisible border and making it invisible, perhaps it…
guotaoAuthorUnsubmitted
Done

What Item? Sorry I am newbie for QML.
I tried Item, Object and all of them not work

guotao: What Item? Sorry I am newbie for QML. I tried Item, Object and all of them not work
rkflxUnsubmitted
Done

What Item? Sorry I am newbie for QML.
I tried Item, Object and all of them not work

@ngraham Ping?

rkflx: > What Item? Sorry I am newbie for QML. > I tried Item, Object and all of them not work…
rkflxUnsubmitted
Done

@ngraham When changing to Item, for me the background of the magnifier got transparent instead of white when operating near the edges of the screen. Is there a better way you have in mind?

@guotao I guess you should add a comment to that effect to the code, so future readers will also understand why you chose a Rectangle.

rkflx: @ngraham When changing to `Item`, for me the background of the magnifier got transparent…
292​ clip: true
293​
294​ Image {
295​ id: crossBackground;
296​ objectName: "crossBackground";
297​ source: "image://snapshot/rawimage";
298​ cache: false;
rkflxUnsubmitted
Done

Are you sure false is the right choice here? The docs say "at the expense of small 'ui element' images", but I don't see any of those. IIUC this is about caching the image on the GPU, which to me sounds sensible in this case…

rkflx: Are you sure `false` is the right choice here? The docs say "at the expense of small 'ui…
guotaoAuthorUnsubmitted
Done

I just follow the exist code.
After set to true, it seem works well.

guotao: I just follow the exist code. After set to true, it seem works well.
rkflxUnsubmitted
Done

Okay. But if it works well for you on real hardware, I'd tend to go with enabling the cache. Let me investigate this more and possibly change it in the other place too.

For crossBackground, you can remove the line for now, because the default value is already true.

rkflx: Okay. But if it works well for you on real hardware, I'd tend to go with enabling the cache.
rkflxUnsubmitted
Done

Why is this marked as "Done" when the line is still there?

rkflx: Why is this marked as "Done" when the line is still there?
299​ smooth: false;
300​ height: Window.height * magZoom;
301​ width: Window.width * magZoom;
302​ fillMode: Image.PreserveAspectCrop;
rkflxUnsubmitted
Done

Is this needed?

rkflx: Is this needed?
guotaoAuthorUnsubmitted
Done

It seems my debug code but not removed.
after remove, works well.

guotao: It seems my debug code but not removed. after remove, works well.
303​ }
304​
305​ Rectangle {
306​ x: magPixels * magZoom;
307​ y: 0;
308​ width: magZoom;
309​ height: magPixels * magZoom;
310​ color: crossColour;
311​ }
312​
313​ Rectangle {
314​ x: magPixels * magZoom;
315​ y: (magPixels + 1) * magZoom;
316​ width: magZoom;
317​ height: magPixels * magZoom;
318​ color: crossColour;
319​ }
320​
321​ Rectangle {
322​ x: 0;
323​ y: magPixels * magZoom;
324​ width: magPixels * magZoom;
325​ height: magZoom;
326​ color: crossColour;
327​ }
328​
329​ Rectangle {
330​ x: (magPixels + 1) * magZoom;
331​ y: magPixels * magZoom;
332​ width: magPixels * magZoom;
333​ height: magZoom;
334​ color: crossColour;
335​ }
336​ }
337​
244 } 338​ }
245 339​
246 MouseArea { 340​ MouseArea {
247 anchors.fill: imageBackground; 341​ anchors.fill: imageBackground;
248 342​
249 property int startx: 0; 343​ property int startx: 0;
250 property int starty: 0; 344​ property int starty: 0;
251 345​
Show All 16 Lines349 onPressed: {
268 }); 362​ });
269 } 363​ }
270 364​
271 onPositionChanged: { 365​ onPositionChanged: {
272 selection.x = Math.min(startx, mouse.x); 366​ selection.x = Math.min(startx, mouse.x);
273 selection.y = Math.min(starty, mouse.y); 367​ selection.y = Math.min(starty, mouse.y);
274 selection.width = Math.abs(startx - mouse.x) + 1; 368​ selection.width = Math.abs(startx - mouse.x) + 1;
275 selection.height = Math.abs(starty - mouse.y) + 1; 369​ selection.height = Math.abs(starty - mouse.y) + 1;
276 370​ selection.zx = mouse.x;
371​ selection.zy = mouse.y;
277 cropDisplayCanvas.requestPaint(); 372​ cropDisplayCanvas.requestPaint();
278 } 373​ }
279 374​
280 onClicked: { 375​ onClicked: {
281 if ((mouse.button == Qt.RightButton) && (selection)) { 376​ if ((mouse.button == Qt.RightButton) && (selection)) {
282 selection.destroy(); 377​ selection.destroy();
283 cropDisplayCanvas.requestPaint(); 378​ cropDisplayCanvas.requestPaint();
284 } 379​ }
285 } 380​ }
381​
382​ onReleased: {
383​ selection.zx = -1;
384​ selection.zy = -1;
385​ cropDisplayCanvas.requestPaint();
386​ }
286 } 387​ }
287 388​
288 Component { 389​ Component {
289 id: cropRectangle; 390​ id: cropRectangle;
290 391​
291 SelectionRectangle { 392​ SelectionRectangle {
292 drawCanvas: cropDisplayCanvas; 393​ drawCanvas: cropDisplayCanvas;
293 imageElement: imageBackground; 394​ imageElement: imageBackground;
294 395​
295 onDoubleClicked: editorRoot.accept() 396​ onDoubleClicked: editorRoot.accept()
296 } 397​ }
297 } 398​ }
298} 399​}