guotao (Tao Guo)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jan 23 2018, 6:57 AM (82 w, 1 d)
Availability
Available

Recent Activity

Jun 26 2019

guotao added a comment to R40:bfdd0006d19f: S&R: Only add maximum 70 characters context before & after match..

For minimized js/xml, I prefer pretty it first.
The timestamp I mentioned is just an example.
I need the full line most time when I analyze such kernel log, adb log.
This seems a workaroud

^.*keyword

But not convenient.
So,could you please add an option to turn off this feature at least?

Jun 26 2019, 11:57 AM
guotao added a comment to R40:bfdd0006d19f: S&R: Only add maximum 70 characters context before & after match..

Hi, what's the benefit of this change?
Why max length is 70? It's so short on 4K monitor.
When analyze huge log file with timestamp, I can not get full line information


Can you add an option to turn off this feature?
And option for max length?

Jun 26 2019, 7:16 AM

Apr 11 2019

guotao added a comment to D18352: Remember last output save directory.

It seems not isolated for different konsole instances.
Usually I have two konsole instance to save log files. one for serials com, one for adb log.

Apr 11 2019, 3:29 AM · Konsole

Mar 28 2019

guotao added a comment to D18352: Remember last output save directory.

@hindenburg, Thank for your help to make it better.
Actually I tried to use URL instead before, but made the code more complex, so I gave up.

Mar 28 2019, 5:50 AM · Konsole

Mar 27 2019

guotao added a comment to D18352: Remember last output save directory.

Please review and merge if everything is ok.

Mar 27 2019, 5:26 AM · Konsole
guotao updated the diff for D18352: Remember last output save directory.

remove useless changes

Mar 27 2019, 5:25 AM · Konsole
guotao updated the diff for D18352: Remember last output save directory.

adjust var name

Mar 27 2019, 5:22 AM · Konsole

Jan 19 2019

guotao added a comment to D18352: Remember last output save directory.

@ngraham
I think it's no necessary remember the directory across different launches.

  1. User want save log to same directory for two different sessions, they can open two tabs in konsole
  2. User want save log to different directories for two sessions, they can launch two konsole
Jan 19 2019, 10:37 AM · Konsole

Jan 18 2019

guotao updated the test plan for D18352: Remember last output save directory.
Jan 18 2019, 7:09 AM · Konsole
guotao added a reviewer for D18352: Remember last output save directory: Konsole.
Jan 18 2019, 6:48 AM · Konsole
guotao requested review of D18352: Remember last output save directory.
Jan 18 2019, 6:47 AM · Konsole

Jun 22 2018

guotao added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

the border width is 2pixels when QT_DEVICE_PIXEL_RATIO set to 2, but I think should be 1 pixel

Jun 22 2018, 11:05 AM · Spectacle

Apr 27 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.

Can we land this change first?

Apr 27 2018, 2:21 AM

Apr 19 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.

@rkflx @ngraham It's a big change to implement Gwenview style inline tool tip, I think we can change it in later commit.

Apr 19 2018, 11:59 AM

Apr 18 2018

guotao updated the diff for D11599: Add magnifier for rectangle mode.

update diff

Apr 18 2018, 4:36 AM

Apr 17 2018

guotao added inline comments to D11599: Add magnifier for rectangle mode.
Apr 17 2018, 1:10 PM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Update diff

Apr 17 2018, 1:09 PM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Please also review my tool tip.

Apr 17 2018, 4:40 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

@rkflx I add maigc key, so that we can toggle magnifier on/off use alt key

Apr 17 2018, 4:00 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Update diff

Apr 17 2018, 2:51 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Update diff

Apr 17 2018, 2:47 AM
guotao added inline comments to D11599: Add magnifier for rectangle mode.
Apr 17 2018, 2:44 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Update diff

Apr 17 2018, 2:43 AM

Apr 16 2018

guotao added inline comments to D11599: Add magnifier for rectangle mode.
Apr 16 2018, 1:52 PM
guotao updated the test plan for D11599: Add magnifier for rectangle mode.
Apr 16 2018, 11:41 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Update diff

Apr 16 2018, 11:39 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

I see, update diff

Apr 16 2018, 5:20 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Update diff

Apr 16 2018, 4:16 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Add option to enable/disable

Apr 16 2018, 4:13 AM

Apr 13 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.

different result on my side:

Apr 13 2018, 4:04 AM

Apr 12 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.

@rkflx how about the border issue on your side? do you have any idea?

Apr 12 2018, 11:29 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

update diff

Apr 12 2018, 11:28 AM
guotao added a comment to D11599: Add magnifier for rectangle mode.

append video for right bottom case

Apr 12 2018, 6:48 AM

Apr 11 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.

attach video

Apr 11 2018, 3:32 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Update diff, restore the magnifier behavior so that it's same as the video

Apr 11 2018, 2:40 AM

Apr 10 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.
  • The border of the magnifier still looks a bit odd, because only on the top and on the left there is a black line, but this line is missing on the bottom and on the right.

It's strange, because on my side, it's ok

  • Less jumping between displaying inside and outside the selection rectangle, because after every jump the user has to refocus and reorient. I already hinted at other apps with a static magnifier which I would prefer TBH (please try out "Shutter" to see what I mean). I guess if you don't want to go in that direction, you should at least simplify the behaviour in such a way that for each handle there are only two possible configurations: Either inside, or outside.

Actually, my design is follow a most famous IM in China, the magnifier always on right bottom side of mouse.
I don't think static magnifier is a good design. when we adjust the rectangle, I think we need focus nearby the mouse. can you image that mouse on left top but magnifier at right botton?

  • For the handles centered on the edges, the magnifier should be centered in relation to the cursor. This is needed for consistency, e.g. for the top/left corner the magnifier is on the top/left (like right now), for the top/middle handle it is on on the top/middle (still missing), and for the top/right corner it is on the top/right (like right now). Behaviour when moving all the way into a corner is still not ideal, though, so again that's why I'd prefer the static magnifier.

this design is very complex

Apr 10 2018, 2:27 PM

Apr 9 2018

guotao added inline comments to D11599: Add magnifier for rectangle mode.
Apr 9 2018, 5:18 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

update diff

Apr 9 2018, 5:15 AM

Apr 8 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.

I don't like all these hardcoded colors. Can't we derive these from the theme?

Apr 8 2018, 7:40 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

update diff

Apr 8 2018, 4:56 AM

Mar 28 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.

I noticed a bug: when you drag from a side handle, the magnifier follows the cursor, not the handle.

I think that's a feature, because you might be interested in other areas than just the surroundings of the handle.

Mar 28 2018, 2:33 AM

Mar 27 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.

Regarding size and zoom, you can adjust magZoom and magPixels.
Regarding the position, IMO, it doesn't matter whether inside or outside, just at bottom right side of the cursor. simple and less code logic

Mar 27 2018, 4:25 AM
guotao added a comment to D11599: Add magnifier for rectangle mode.

Below is my design

Mar 27 2018, 4:17 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Clean code

Mar 27 2018, 4:11 AM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Update Diff

Mar 27 2018, 4:04 AM

Mar 26 2018

guotao added a dependency for D11704: Fix right/bottom edge jump issue when adjust rect: D11598: Fix rectangle selection edge not follow mouse.
Mar 26 2018, 4:15 AM
guotao added a dependent revision for D11598: Fix rectangle selection edge not follow mouse: D11704: Fix right/bottom edge jump issue when adjust rect.
Mar 26 2018, 4:15 AM
guotao updated the diff for D11704: Fix right/bottom edge jump issue when adjust rect.

Update diff

Mar 26 2018, 4:09 AM
guotao requested review of D11704: Fix right/bottom edge jump issue when adjust rect.
Mar 26 2018, 4:05 AM
guotao added a comment to D11598: Fix rectangle selection edge not follow mouse.

Thank you ngraham
Tao Guo <guotao945@gmail.com>

Mar 26 2018, 3:44 AM
guotao updated the diff for D11598: Fix rectangle selection edge not follow mouse.

update diff

Mar 26 2018, 2:35 AM

Mar 25 2018

guotao updated the diff for D11598: Fix rectangle selection edge not follow mouse.

just update diff, prev diff is still wrong

Mar 25 2018, 9:21 AM
guotao updated the diff for D11598: Fix rectangle selection edge not follow mouse.

just update diff, prev diff miss some changes

Mar 25 2018, 9:18 AM
guotao updated the diff for D11598: Fix rectangle selection edge not follow mouse.
  1. fix wrong rect width and height the pixels is start from 0, so the width should be start_offset - end_offset + 1
  2. fix right and bottom edge move unexpected bug
    1. select a rect, make sure the right/bottom edge is beside moniter edge
    2. drag the topleft, top, top right up quickly or drage top left, left, bottom left to left quickly, the bottom/ right edge move unexpected to fix this issue, just set x/y before width/height
Mar 25 2018, 9:18 AM

Mar 24 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.

just like this:

Mar 24 2018, 7:23 AM

Mar 23 2018

guotao added a comment to D11599: Add magnifier for rectangle mode.
  1. This patch add a magnifier for pixels around mouse. it can help us to precision cutting image
Mar 23 2018, 4:30 PM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

improve precision

Mar 23 2018, 12:45 PM
guotao updated the diff for D11599: Add magnifier for rectangle mode.

Fix HiDPI support

Mar 23 2018, 11:28 AM
guotao requested review of D11599: Add magnifier for rectangle mode.
Mar 23 2018, 8:41 AM
guotao requested review of D11598: Fix rectangle selection edge not follow mouse.
Mar 23 2018, 8:29 AM

Feb 5 2018

guotao added a comment to D10033: Add support of drag-and-drop to open files.

I have no commit push rights. You can push this commit to git use below info:
Tao Guo <guotao945@gmail.com>

Feb 5 2018, 1:59 AM
guotao updated the diff for D10033: Add support of drag-and-drop to open files.

Update patch

Feb 5 2018, 1:52 AM

Jan 23 2018

guotao retitled D10033: Add support of drag-and-drop to open files from Add drag-and-drop to open files to Add support of drag-and-drop to open files.
Jan 23 2018, 7:53 AM