Create Task
Maniphest T8082

Icon themes on build.kde.org?
Closed, ResolvedPublic
Actions

Description

Today I pushed a change to KWin which fails on the CI system. My interpretation is that this is due to no icon theme being installed. Is it possible to make an icon theme available to the run tests or should I try to workaround in the tests?

The relevant commit is 5795fc8cc04a422194e06d20fb395cbbf3ea2ad6 and it broke the testInternalWindow and testShellClient (and their waylandonly variants). The test verifies that the "wayland" fallback icon is set and we get back that no icon is set at all. This can only happen if there is no icon theme.

Working around the issue would be simple, but would create differences in running the test locally or on CI.

Related Objects

Restricted Application added a subscriber: sysadmin. · View Herald TranscriptFeb 25 2018, 4:18 PM
bcooksley moved this task from Backlog to Awaiting Response on the build.kde.org board.Feb 25 2018, 7:24 PM

The fix in this case will be for KWin to declare a dependency on breeze-icons in the build metadata, although I thought that was a Framework...

Was this icon recently added by any chance?

graesslin added a comment.Feb 25 2018, 8:22 PM
In T8082#130462, @bcooksley wrote:

The fix in this case will be for KWin to declare a dependency on breeze-icons in the build metadata, although I thought that was a Framework...

Was this icon recently added by any chance?

no, it's around for years.

bcooksley added a comment.Feb 25 2018, 8:42 PM

Only other thing I can think of is that the tests rely on the theme being set to Breeze/Oxygen, which won't be the case on the CI - the theme name simply isn't set.

Could you try explicitly setting the theme you want to use?

graesslin added a comment.Feb 26 2018, 8:29 PM
In T8082#130467, @bcooksley wrote:

Only other thing I can think of is that the tests rely on the theme being set to Breeze/Oxygen, which won't be the case on the CI - the theme name simply isn't set.

Could you try explicitly setting the theme you want to use?

Yes that could be a good explanation. I'll give that a try in a few days (after the CI has settled again, don't want to create additional burden).

bcooksley added a comment.Feb 27 2018, 8:38 AM

Okay awesome. The maintenance is basically done and Linux builds should already be caught up so feel free to proceed with testing this out.
Windows builds will take some time to get back up to speed again but that is a separate set of builders (Jenkins allocation wise)

graesslin closed this task as Resolved.Feb 27 2018, 5:46 PM
graesslin claimed this task.

worked.